Skip to content

Fix flaky upgrade-dependency-version test #7242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knutwannheden merged 2 commits into from
Apr 2, 2026
+9 −5
Merged

Fix flaky upgrade-dependency-version test #7242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e4f670
Fix flaky upgrade-dependency-version test
knutwannheden Apr 2, 2026
eb9f65f
Fix flaky add-dependency test for lodash version check
knutwannheden Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions rewrite-javascript/rewrite/test/javascript/recipes/add-dependency.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import {Json} from "../../../src/json";
import {RecipeSpec} from "../../../src/test";
import {withDir} from "tmp-promise";
import {findMarker, MarkersKind} from "../../../src";
import * as semver from "semver";

describe("AddDependency", () => {

Expand Down Expand Up @@ -346,10 +347,10 @@ describe("AddDependency", () => {
throw new Error(`Expected root dependency lodash to be ^4.17.21, got ${rootPkg?.dependencies?.["lodash"]}`);
}

// lodash should be in node_modules
// lodash should be in node_modules with a version satisfying ^4.17.21
const lodashPkg = lockData.packages["node_modules/lodash"];
if (!lodashPkg?.version?.startsWith("4.17.")) {
throw new Error(`Expected lodash version to start with 4.17., got ${lodashPkg?.version}`);
if (!lodashPkg?.version || !semver.satisfies(lodashPkg.version, "^4.17.21")) {
throw new Error(`Expected lodash version satisfying ^4.17.21, got ${lodashPkg?.version}`);
}

return actual;
Expand Down
7 changes: 5 additions & 2 deletions rewrite-javascript/rewrite/test/javascript/recipes/upgrade-dependency-version.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import {RecipeSpec} from "../../../src/test";
import {withDir} from "tmp-promise";
import * as fs from "fs";
import * as path from "path";
import * as semver from "semver";

describe("UpgradeDependencyVersion", () => {

Expand Down Expand Up @@ -505,9 +506,11 @@ describe("UpgradeDependencyVersion", () => {
const marker = findNodeResolutionResult(doc);
expect(marker).toBeDefined();
expect(marker!.dependencies[0].versionConstraint).toBe("^4.17.23");
// The resolved version should still be 4.17.23 (unchanged)
// The resolved version should still satisfy ^4.17.23 (unchanged)
// This proves we didn't run npm install - just updated the constraint
expect(marker!.resolvedDependencies?.[0]?.version).toBe("4.17.23");
const resolvedVersion = marker!.resolvedDependencies?.[0]?.version;
expect(resolvedVersion).toBeDefined();
expect(semver.satisfies(resolvedVersion!, "^4.17.23")).toBe(true);
}
}
)
Expand Down