Address feedback on Lamda page #9895
Conversation
Signed-off-by: Naarcha-AWS <[email protected]>
Naarcha-AWS
requested review from
kolchfa-aws,
AMoo-Miki,
natebower,
dlvenable and
epugh
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
| @@ -29,18 +28,24 @@ Field | Type | Required | Description | |||
| `lambda_when` | String | Optional | A conditional expression that determines when to invoke the Lambda processor. | |||
| `response_codec` | Object | Optional | A codec configuration for parsing Lambda responses. Default is `json`. | |||
| `tags_on_match_failure` | List | Optional | A list of tags to add to events when Lambda matching fails or encounters an unexpected error. | |||
| `sdk_timeout` | Duration| Optional | Configures the SDK's client connection timeout period. Default is `60s`. | |||
| `sdk_timeout` | Duration | Optional | Configures the SDK's client connection timeout period. Default is `60s`. | |||
There was a problem hiding this comment.
this was renamed to connection_timeout, we can update other fields as well - reference-link
Co-authored-by: David Venable <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]>
| `response_events_match` | Boolean | Optional | Specifies how Data Prepper interprets and processes Lambda function responses. Default is `false`. | ||
|
|
||
| #### Example configuration | ||
| The `invocation_type` field is not supported in Amazon OpenSearch Ingestion pipelines using the `aws_lambda` processor. Including this field will result in a validation error. |
There was a problem hiding this comment.
Why is this field in the table above if it is not supported? Are there discrepancies between these docs and what AWS supports? If so are they documented anywhere? In my mind adding just this blurb adds more confusion.
There was a problem hiding this comment.
There was a problem hiding this comment.
@dlvenable or @srikanthjg: Is there an alternative method or parameter for adjusting the invocation_type? Should we just remove the field and section from the docs entirely?
There was a problem hiding this comment.
for opensource dataprepper, this field is needed an is used in both lambda processor and sink.
-
request-response (default for the processor): This is mapped to AWS Lambda's
"RequestResponse" invocation type. When using this mode. This is synchronous processing, where the pipeline waits for the Lambda result -
event (default for the sink): This is mapped to AWS Lambda's "Event" invocation type.
When using this mode The request is sent to Lambda asynchronously and Data Prepper doesn't wait for a response
Co-authored-by: David Venable <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
|
@dlvenable: Can you take another look at this one? |
Signed-off-by: Naarcha-AWS <[email protected]>
Issues Resolved
Closes #9872
Frontend features
If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.