-
Notifications
You must be signed in to change notification settings - Fork 602
Address feedback on Lamda page #9895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Naarcha-AWS
wants to merge
6
commits into
main
Choose a base branch
from
data-prepper-feedback
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
efc3245
Address feedback on Lamda page
Naarcha-AWS 7249728
Merge branch 'main' into data-prepper-feedback
Naarcha-AWS 2f0a15e
Apply suggestions from code review
Naarcha-AWS 770e93d
Apply suggestions from code review
Naarcha-AWS 13f9237
Update aws-lambda.md
Naarcha-AWS f297671
Apply suggestions from code review
Naarcha-AWS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this field in the table above if it is not supported? Are there discrepancies between these docs and what AWS supports? If so are they documented anywhere? In my mind adding just this blurb adds more confusion.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rpash: Based on your experience (issue #9872), that would seem to be the case. That being said, I have no additional insight on what additional discrepancies may exist between Data Prepper, OSI, and what AWS supports. This PR is only meant to address feedback on the AWS Lamda page specifically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dlvenable or @srikanthjg: Is there an alternative method or parameter for adjusting the
invocation_type
? Should we just remove the field and section from the docs entirely?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for opensource dataprepper, this field is needed an is used in both lambda processor and sink.
request-response (default for the processor): This is mapped to AWS Lambda's
"RequestResponse" invocation type. When using this mode. This is synchronous processing, where the pipeline waits for the Lambda result
event (default for the sink): This is mapped to AWS Lambda's "Event" invocation type.
When using this mode The request is sent to Lambda asynchronously and Data Prepper doesn't wait for a response