Skip to content

[v3.0.0] Deprecate SQL Delete statement#3337

Merged
dai-chen merged 7 commits intoopensearch-project:mainfrom
dai-chen:deprecate-delete-statement
Feb 25, 2025
Merged

[v3.0.0] Deprecate SQL Delete statement#3337
dai-chen merged 7 commits intoopensearch-project:mainfrom
dai-chen:deprecate-delete-statement

Conversation

@dai-chen
Copy link
Copy Markdown
Collaborator

@dai-chen dai-chen commented Feb 19, 2025 •
edited
Loading

Description

This PR removes the SQL DELETE statement and the associated plugin setting plugins.sql.delete.enabled from the codebase, doctests, and documentation.

Note: There are still legacy code related to the DELETE statement inherited from NLPChina. Since we've been working on Calcite integration, I am leaving that legacy code untouched for now.

Related Issues

Resolves #3281

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dai-chen dai-chen self-assigned this Feb 19, 2025
@dai-chen
Remove all delete statement related code and docs
0df7d17 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen
Fix spotless
44829d2 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen
Remove doctest
288bc31 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen dai-chen force-pushed the deprecate-delete-statement branch from ee5e40a to 288bc31 Compare February 20, 2025 19:11
@dai-chen
Fix broken delete IT
23a16ac 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen
Update doc
ea8c267 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen dai-chen marked this pull request as ready for review February 20, 2025 23:00
noCharger
noCharger previously approved these changes Feb 21, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@noCharger noCharger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm. Just curious, are there any backwards compatible test cases for the delete statement and its associated settings?

@dai-chen
Copy link
Copy Markdown
Collaborator Author

dai-chen commented Feb 21, 2025 •
edited
Loading

Overall lgtm. Just curious, are there any backwards compatible test cases for the delete statement and its associated settings?

I didn't find earlier. Let me do another pass.

Or you mean we should add some test for this breaking changes?

@dai-chen
Merge branch 'main' into deprecate-delete-statement
4e27279 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen
Undo import star statements
84a2fff 
Signed-off-by: Chen Dai <daichen@amazon.com>
@noCharger
Copy link
Copy Markdown
Collaborator

noCharger commented Feb 22, 2025

Or you mean we should add some test for this breaking changes?

It's fine if there is no existing bwc test. Also, not sure if we can direct the query to a specific node in a mixed cluster with both new and old nodes.

penghuo
penghuo reviewed Feb 24, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there doc to track 3.0 breaking change? if no, let's create a task to track it.

@dai-chen
Copy link
Copy Markdown
Collaborator Author

dai-chen commented Feb 25, 2025

Is there doc to track 3.0 breaking change? if no, let's create a task to track it.

Sure will do.

@dai-chen dai-chen merged commit f5e7869 into opensearch-project:main Feb 25, 2025
22 checks passed
@dai-chen dai-chen deleted the deprecate-delete-statement branch February 25, 2025 20:55
@xinyual xinyual mentioned this pull request Jun 11, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@penghuo penghuo penghuo approved these changes

@noCharger noCharger noCharger approved these changes

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm

@derek-ho derek-ho Awaiting requested review from derek-ho

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz

@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@forestmvey forestmvey Awaiting requested review from forestmvey

@acarbonetto acarbonetto Awaiting requested review from acarbonetto acarbonetto is a code owner

@GumpacG GumpacG Awaiting requested review from GumpacG

@ykmr1224 ykmr1224 Awaiting requested review from ykmr1224 ykmr1224 is a code owner

@LantaoJin LantaoJin Awaiting requested review from LantaoJin LantaoJin is a code owner

Assignees

@dai-chen dai-chen

Labels

breaking v3.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove DELETE statement support in SQL and remove plugins-sql-delete-enabled

3 participants

@dai-chen @noCharger @penghuo