Skip to content

Conversation

dinhxuanvu
Copy link

@dinhxuanvu dinhxuanvu commented Sep 10, 2025

The Mapped key will hold information regarding mapped images that can be used later for openshift-tests images cmd.

See #openshift/kubernetes#2447

@openshift-ci openshift-ci bot requested review from deads2k and smg247 September 10, 2025 17:05
Copy link

openshift-ci bot commented Sep 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dinhxuanvu
Once this PR has been reviewed and has the lgtm label, please assign smg247 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dinhxuanvu dinhxuanvu marked this pull request as draft September 10, 2025 17:05
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 10, 2025
Copy link

openshift-ci bot commented Sep 10, 2025

Hi @dinhxuanvu. Thanks for your PR.

I'm waiting for a openshift-eng member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 10, 2025
The Mapped key will hold information regarding mapped images that
can be used later for openshift-tests images cmd.

Signed-off-by: Vu Dinh <[email protected]>
@dinhxuanvu dinhxuanvu marked this pull request as ready for review September 17, 2025 04:01
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2025
@openshift-ci openshift-ci bot requested a review from jupierce September 17, 2025 04:01
@dinhxuanvu
Copy link
Author

Related to openshift/kubernetes#2447
@bertinatto @smg247 PTAL

Registry string `json:"registry"`
Name string `json:"name"`
Version string `json:"version"`
Mapped *Image `json:"mapped,omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory external binaries could return values with deeply-nested images, but I believe it's fine because we're only interested in the first level. The other options is to make it flat, but I can go either way.

@smg247 @stbenjam thoughts?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to elaborate on what Fabio said. If the deeply-nested struct is not acceptable, we can do flat struct like this:

type Image struct {
	Index    int         `json:"index"`
	Registry string      `json:"registry"`
	Name     string      `json:"name"`
	Version  string      `json:"version"`
	Mapped   MappedImage `json:"mapped,omitempty"`
}

type MappedImage struct {
	Index    int    `json:"index"`
	Registry string `json:"registry"`
	Name     string `json:"name"`
	Version  string `json:"version"`
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants