-
Notifications
You must be signed in to change notification settings - Fork 21
Add Mapped field to Image struct #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dinhxuanvu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @dinhxuanvu. Thanks for your PR. I'm waiting for a openshift-eng member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The Mapped key will hold information regarding mapped images that can be used later for openshift-tests images cmd. Signed-off-by: Vu Dinh <[email protected]>
8d7c70e
to
006a0f6
Compare
Related to openshift/kubernetes#2447 |
Registry string `json:"registry"` | ||
Name string `json:"name"` | ||
Version string `json:"version"` | ||
Mapped *Image `json:"mapped,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to elaborate on what Fabio said. If the deeply-nested struct is not acceptable, we can do flat struct like this:
type Image struct {
Index int `json:"index"`
Registry string `json:"registry"`
Name string `json:"name"`
Version string `json:"version"`
Mapped MappedImage `json:"mapped,omitempty"`
}
type MappedImage struct {
Index int `json:"index"`
Registry string `json:"registry"`
Name string `json:"name"`
Version string `json:"version"`
}
The Mapped key will hold information regarding mapped images that can be used later for openshift-tests images cmd.
See #openshift/kubernetes#2447