Skip to content

Add Mapped field to Image struct #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Mapped field to Image struct #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/extension/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,4 +88,5 @@ type Image struct {
Registry string `json:"registry"`
Name string `json:"name"`
Version string `json:"version"`
Mapped *Image `json:"mapped,omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory external binaries could return values with deeply-nested images, but I believe it's fine because we're only interested in the first level. The other options is to make it flat, but I can go either way.

@smg247 @stbenjam thoughts?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to elaborate on what Fabio said. If the deeply-nested struct is not acceptable, we can do flat struct like this:

type Image struct {
	Index    int         `json:"index"`
	Registry string      `json:"registry"`
	Name     string      `json:"name"`
	Version  string      `json:"version"`
	Mapped   MappedImage `json:"mapped,omitempty"`
}

type MappedImage struct {
	Index    int    `json:"index"`
	Registry string `json:"registry"`
	Name     string `json:"name"`
	Version  string `json:"version"`
}

}