feat: Implement check for DockerfileGen configuration in image generation process and skip if not set #41
Conversation
…rocess and skip if not set
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rhuss The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| func (o Operation) generateImages(rel release) step { | ||
| return func() error { | ||
| // Check if DockerfileGen configuration is provided | ||
| if o.Config.SkipImage { |
There was a problem hiding this comment.
Can't we skip based on the o.Config.DockerfileGen not being configured, instead of introducing this flag?
There was a problem hiding this comment.
Well, I tried this first. But since it is always initialized with the default values, its never empty. If you an easier idea to do this (maybe with pointers or not using default for DockerfileGen), I'm all ears as I don't like this solution much either.
There was a problem hiding this comment.
Maybe we could create a wrapper struct around dockerfilegen.Params, and add a skip param there. It should still be able to unmarshal, right? Let me check...
2 participants
No description provided.