🎁 Allow to skip dockerfilegen #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cardil The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cardil
force-pushed
the
feature/skip-dockerfilegen
branch
3 times, most recently
from
f6daee0 to
4259467
Compare
cardil
force-pushed
the
feature/skip-dockerfilegen
branch
from
4259467 to
cc921be
Compare
cardil
force-pushed
the
feature/skip-dockerfilegen
branch
from
cc921be to
9a7ddcb
Compare
openshift-merge-bot
bot
merged commit ac427df
into
openshift-knative:main
4 checks passed
Contributor
|
yeah, it's cleaner from a UI perspective. Actually, I didn't want to touch dockerfilegen params as they were imported from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to skip dockerfile gen
Closes #41
/cc @rhuss