Update lint settings from openshift/enhancements#6
Update lint settings from openshift/enhancements#6danielmellado wants to merge 1 commit intoopenshift-kni:mainfrom
Conversation
This commit updates the linting settings and ths optional sections from the original openshift/enhancements repo. Signed-off-by: Daniel Mellado <dmellado@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: serngawy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| blanks-around-fences: false | ||
| blanks-around-headings: false |
There was a problem hiding this comment.
From the comment it looks like openshift/enhancements wanted these on but couldn't for historical reasons. Any reason we shouldn't start with them? I can go either way...
There was a problem hiding this comment.
I'd keep this in sync 1:1 with openshift/enhancements. Basically I'd rather keep compatibility in case one of the EP in kni would have to move over there or the other way around. Besides that, checking the code this rule seems to have been there since start.
3 participants
This commit updates the linting settings and ths optional sections from
the original openshift/enhancements repo.
Signed-off-by: Daniel Mellado dmellado@redhat.com