Skip to content

Update lint settings from openshift/enhancements #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danielmellado wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update lint settings from openshift/enhancements #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .markdownlint-cli2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,13 @@ config:

# Vertical whitespace helps the reader, so we should turn these on
# again when someone has time to fix our existing files.
blanks-around-fences: true
blanks-around-headings: true
blanks-around-fences: false
blanks-around-headings: false
Comment on lines +42 to +43
Copy link
Contributor

@imiller0 imiller0 Jul 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the comment it looks like openshift/enhancements wanted these on but couldn't for historical reasons. Any reason we shouldn't start with them? I can go either way...

Copy link
Collaborator Author

@danielmellado danielmellado Jul 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd keep this in sync 1:1 with openshift/enhancements. Basically I'd rather keep compatibility in case one of the EP in kni would have to move over there or the other way around. Besides that, checking the code this rule seems to have been there since start.

blanks-around-lists: false
single-trailing-newline: true
no-multiple-blanks: false

# Trailing spaces don't cause any known issues and are often introduced when
# Trailing spaces don't cause any known issues and are often introduced when
# updating text to conform to max line length restrictions.
no-trailing-spaces: false

Expand Down