-
Notifications
You must be signed in to change notification settings - Fork 573
OCPBUGS-55465: Drop on-by-default ValidatingAdmissionPolicy featuregate #2306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-55465: Drop on-by-default ValidatingAdmissionPolicy featuregate #2306
Conversation
@JoelSpeed: This pull request references Jira Issue OCPBUGS-55465, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Hello @JoelSpeed! Some important instructions when contributing to openshift/api: |
/approve cancel |
@JoelSpeed: This pull request references Jira Issue OCPBUGS-55465, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
4be19c2
to
390e654
Compare
/hold cancel |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@JoelSpeed: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
9bbe393
into
openshift:master
@JoelSpeed: Jira Issue OCPBUGS-55465: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-55465 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-config-api |
This was inadvertently shipped in 4.17. We will now need to proceed with it as an upstream API removal, which is to be handled by the linked bug.
Once the removal warnings have been put in place, this can then be removed. Putting this up as a placeholder.
NOT to be merged until users cannot upgrade from 4.19 if they are using the v1beta1 version of this API.
/hold