OCPBUGS-55465: Stop serving admissionregistration.k8s.io/v1beta1. #1836
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@benluddy: This pull request references Jira Issue OCPBUGS-55465, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
|
/lgtm |
|
/hold We have some platform components depending on this GV by mistake, holding until those are switched over to v1. |
openshift-ci
bot
added
the
do-not-merge/hold
|
Should be okay to unhold after openshift/kubernetes#2290. |
ValidatingAdmissionPolicy currently depends on admissionregistration.k8s.io/v1 and the feature gate is always on. The v1beta1 version wasn't meant to be served outside of tech preview clusters.
benluddy
force-pushed
the
stop-serving-admissionregistration-v1beta1
branch
from
6bae557 to
0bdba4f
Compare
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@benluddy: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
|
/cc @JoelSpeed |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy, jacobsee, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 5cc2e26
into
openshift:main
|
@benluddy: Jira Issue OCPBUGS-55465: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-55465 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-kube-apiserver-operator |
ValidatingAdmissionPolicy currently depends on admissionregistration.k8s.io/v1 and the feature gate is always on. The v1beta1 version wasn't meant to be served outside of tech preview clusters.
Resumes the work started in #1687.