OCPBUGS-55673: Remove IngressControllerLBSubnetsAWS featuregate #2400
Conversation
|
Hello @grzpiotrowski! Some important instructions when contributing to openshift/api: |
openshift-ci-robot
added
jira/valid-reference
|
@grzpiotrowski: This pull request references Jira Issue OCPBUGS-55673, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
size/XXL
grzpiotrowski
force-pushed
the
OCPBUGS-55673-remove-ic-lb-subnets-aws-featuregate
branch
from
af3ae97 to
1f8364b
Compare
...v1/zz_generated.crd-manifests/0000_50_ingress_00_ingresscontrollers-CustomNoUpgrade.crd.yaml
Outdated
Show resolved
Hide resolved
grzpiotrowski
force-pushed
the
OCPBUGS-55673-remove-ic-lb-subnets-aws-featuregate
branch
from
1f8364b to
5a3f389
Compare
openshift-merge-robot
added
the
needs-rebase
grzpiotrowski
force-pushed
the
OCPBUGS-55673-remove-ic-lb-subnets-aws-featuregate
branch
from
5a3f389 to
64b9aad
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/lgtm Assuming all goes green, this is good to go |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grzpiotrowski, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Thank you @JoelSpeed. |
|
/hold until openshift/cluster-ingress-operator#1242 merges |
openshift-ci
bot
added
the
do-not-merge/hold
The IngressControllerLBSubnetsAWS feature gate was at first introduced as TPNU in OpenShift 4.17 and was promoted to Default in the same release. The feature gate has been enabled by default for 3 releases, so it is scheduled to be removed imminently. This commit addresses OCPBUGS-55673: https://issues.redhat.com/browse/OCPBUGS-55673
grzpiotrowski
force-pushed
the
OCPBUGS-55673-remove-ic-lb-subnets-aws-featuregate
branch
from
64b9aad to
314f417
Compare
|
New changes are detected. LGTM label has been removed. |
|
@JoelSpeed openshift/cluster-ingress-operator#1242 is going in. When I did I0825 17:52:28.487123 694687 main.go:75] Completed successfully.
+ ret=0
+ git diff --exit-code --quiet
+ ret=1
+ [[ 1 -ne 0 ]]
+ echo 'Prerelease lifecycle generation is out of date. Please run hack/update-prerelease-lifecycle-gen.sh'
Prerelease lifecycle generation is out of date. Please run hack/update-prerelease-lifecycle-gen.sh
+ exit 1
make: *** [Makefile:71: verify-scripts] Error 1I ran the mentioned hack script but it did not cause any changes. Is this something to be worried? |
|
@grzpiotrowski: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@grzpiotrowski I believe the verification already runs that hack script and then checks to see if there was a diff afterwards - which it seems to have found. After running the |
Hm, I just ran |
The
IngressControllerLBSubnetsAWSfeature gate was at first introduced as TPNU in OpenShift 4.17 and was promoted to Default in the same release. The feature gate has been enabled by default for 3 releases and it is scheduled to be removed.This PR depends on the merge of: openshift/cluster-ingress-operator#1242