OCPBUGS-55673: Remove IngressControllerLBSubnetsAWS featuregate #1242
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@grzpiotrowski: This pull request references Jira Issue OCPBUGS-55673, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest I couldn't see anything related to the changes. |
|
/assign @rfredette |
|
/retest |
1 similar comment
|
/retest |
|
/test e2e-aws-ovn-single-node |
|
/unassign @rfredette |
|
/assign |
|
The commit message is missing a line break here: Edit: Actually, you have |
|
Also, the commit message has an extra "desiredLoadBalancerService" here: |
The IngressControllerLBSubnetsAWS feature gate was at first introduced as TPNU in OpenShift 4.17 and was promoted to Default in the same release. The feature gate has been enabled by default for 3 releases, so it is scheduled to be removed imminently. The feature itself (ability to choose AWS subnets for LoadBalancer Service) remains, only the feature gate check is removed. This commit addresses OCPBUGS-55673: https://issues.redhat.com/browse/OCPBUGS-55673 Follow-up to the commit which introduced the feature gate: openshift@26dfe2c * pkg/operator/controller/ingress/controller.go: Remove IngressControllerLBSubnetsAWSEnabled from Config. * pkg/operator/controller/ingress/load_balancer_service.go: (desiredLoadBalancerService): Remove subnetsAWSEnabled featuregate checks and the redundant function parameter. (loadBalancerServiceIsUpgradeable): Remove featuregate check from the LB Service upgradeability calculation. (loadBalancerServiceIsProgressing): Remove featuregate check from LB Service progressing calculation. * pkg/operator/controller/ingress/load_balancer_service_test.go: Update desiredLoadBalancerService function calls after removing the subnetsAWSEnabled parameter. * pkg/operator/controller/ingress/status.go: (syncIngressControllerStatus): Remove LBSubnetsAWS featuregate check from the IC status computation. (computeIngressUpgradeableCondition): Remove subnetsAWSEnabled featuregate check. (computeLoadBalancerProgressingStatus): Remove subnetsAWSEnabled from the LB progressing status computation. * pkg/operator/controller/ingress/status_test.go (Test_computeLoadBalancerProgressingStatus): Remove test case with the LBSubnetsAWS featuregate disabled. Remove awsSubnetsEnabled boolean since it is not needed anymore. (Test_computeIngressUpgradeableCondition): Update function calls after the featuregate check paramter was removed. (Test_computeIngressEvaluationConditionsDetectedCondition): Update function calls after the featuregate check parameter was removed. * pkg/operator/operator.go: (New): Remove ingressControllerLBSubnetsAWSEnabled featuregate check. * test/e2e/lb_subnets_test.go: (TestAWSLBSubnets): Remove featuregate check. (TestUnmanagedAWSLBSubnets): Remove featuregate check.
grzpiotrowski
force-pushed
the
OCPBUGS-55673-remove-ic-lb-subnets-aws-featuregate
branch
from
18cb81d to
cc00436
Compare
|
@grzpiotrowski: This pull request references Jira Issue OCPBUGS-55673, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
|
|
overall lgtm, not sure if this needs to be removed also from some API, but I have checked some other project code and couldn't find any reference to this feature flag /cc @candita for final review |
|
@rikatz this is removed from openshift/api in openshift/api#2400, but this PR needs to merge first. @grzpiotrowski Nice job on the commit message! /override e2e-gcp-operator |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: candita The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@candita: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override /ci/prow/e2e-gcp-operator |
|
@candita: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/e2e-gcp-operator |
|
@candita: Overrode contexts on behalf of candita: ci/prow/e2e-gcp-operator In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
2 similar comments
|
/override ci/prow/e2e-gcp-operator |
|
@candita: Overrode contexts on behalf of candita: ci/prow/e2e-gcp-operator In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest-required |
|
@grzpiotrowski: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/jira refresh The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity. |
openshift-ci-robot
added
jira/invalid-bug
|
@openshift-bot: This pull request references Jira Issue OCPBUGS-55673, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@grzpiotrowski: This pull request references Jira Issue OCPBUGS-55673, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
The IngressControllerLBSubnetsAWS feature gate was at first introduced as TPNU in OpenShift 4.17 and was promoted to Default in the same release. The feature gate has been enabled by default for 3 releases, so it is scheduled to be removed imminently.
The feature itself (ability to choose AWS subnets for LoadBalancer Service) remains, only the feature gate check is removed.
Follow-up to the commit which introduced the feature gate: 26dfe2c
Feature was added as TPNU in: openshift/api#1841
Feature was promoted to Default (GA) in: openshift/api#1966