remove redundant minimal etcd ServiceMonitor

[lance5890]

1. When we run kubectl get ServiceMonitor -n openshift-etcd-operator, we can see both etcd and etcd-minimal exist.
   [root@provisioning ~]# kubectl get ServiceMonitor -n openshift-etcd-operator
   NAME AGE
   etcd 99d
   etcd-minimal 99d
   etcd-operator 99d

2. The monitoring.openshift.io/collection-profile annotation is used by the Cluster Monitoring Operator (CMO), as shown in the source code: https://github.com/openshift/cluster-monitoring-operator/blob/289e250e6b7f70c546caf0be8a9fb507a2becc06/pkg/manifests/manifests.go#L1381

3. However, the Cluster Etcd Operator (CEO) does not recognize the monitoring.openshift.io/collection-profile annotation to determine which ServiceMonitor to apply (minimal or full).

4. Therefore, I propose removing the etcd-minimal ServiceMonitor and keeping only the full etcd ServiceMonitor.

related PR:
#1070
openshift/cluster-monitoring-operator#2039

[coderabbitai]

Walkthrough

Removed the etcd minimal ServiceMonitor manifest, dropped a label from the full ServiceMonitor, and updated the operator starter to stop bundling the deleted minimal manifest. No other logic or fields changed.

Changes

Cohort / File(s)	Summary
Etcd ServiceMonitor manifests bindata/etcd/minimal-sm.yaml, bindata/etcd/sm.yaml	Deleted minimal-sm.yaml ServiceMonitor. In sm.yaml, removed label monitoring.openshift.io/collection-profile: full.
Operator starter static resources pkg/operator/starter.go	Removed reference to etcd/minimal-sm.yaml from static resource bundle initialization.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title succinctly describes the main change of the pull request, specifically the removal of the redundant minimal etcd ServiceMonitor, and it is clear and specific enough for a reviewer to understand the primary focus at a glance.
Description Check	✅ Passed	The description clearly explains why the minimal etcd ServiceMonitor is redundant, references the existing ServiceMonitors and annotation usage, and outlines the rationale for its removal, directly matching the changes made in the pull request.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 3b399a9 and 1bf8f19.

📒 Files selected for processing (3)

• bindata/etcd/minimal-sm.yaml (0 hunks)
• bindata/etcd/sm.yaml (0 hunks)
• pkg/operator/starter.go (0 hunks)

💤 Files with no reviewable changes (3)

• pkg/operator/starter.go
• bindata/etcd/minimal-sm.yaml
• bindata/etcd/sm.yaml

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lance5890
Once this PR has been reviewed and has the lgtm label, please assign hasbro17 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @lance5890. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[lance5890]

ceo does not recognize this annotation

[tjungblu]

@simonpasquier / @machine424 is it safe to delete? or did we make the mistake to not honor some global configuration? I assume this was used to reduce the amount of metrics going to Prometheus in CMO at some point in time.

[machine424]

Although both service monitors are present, only one should be considered (labels are used to select the appropriate one based on the profile. The selection is handled by the monitoring stack (prometheus-operator), CEO doesn't have to know about that.)
Are you seeing duplicate metrics in prometheus?

[tjungblu]

I defer this to @lance5890 - I assume he just cleaned it up based on being unused here

[machine424]

the config/customization happens on the monitoring side
https://docs.redhat.com/en/documentation/openshift_container_platform/4.19/html/monitoring/about-openshift-container-platform-monitoring#configuring-metrics-collection-profiles_key-concepts
https://docs.redhat.com/en/documentation/openshift_container_platform/4.19/html/monitoring/configuring-core-platform-monitoring#choosing-a-metrics-collection-profile_configuring-performance-and-scalability

maybe a comment can be added on the etcd service monitors about that.

[lance5890]

yes, The prometheuse select the smon as:

the config/customization happens on the monitoring side https://docs.redhat.com/en/documentation/openshift_container_platform/4.19/html/monitoring/about-openshift-container-platform-monitoring#configuring-metrics-collection-profiles_key-concepts https://docs.redhat.com/en/documentation/openshift_container_platform/4.19/html/monitoring/configuring-core-platform-monitoring#choosing-a-metrics-collection-profile_configuring-performance-and-scalability

maybe a comment can be added on the etcd service monitors about that.