Skip to content

remove redundant minimal etcd ServiceMonitor #1499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

remove redundant minimal etcd ServiceMonitor #1499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9cfcab
rm etcd-minimal ServiceMonitor
lance5890 Oct 14, 2025
1bf8f19
rm collection-profile anno for etcd-full smon
lance5890 Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 0 additions & 38 deletions bindata/etcd/minimal-sm.yaml
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion bindata/etcd/sm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ metadata:
labels:
app.kubernetes.io/name: etcd
k8s-app: etcd
monitoring.openshift.io/collection-profile: full
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ceo does not recognize this annotation

spec:
endpoints:
- interval: 30s
Expand Down
1 change: 0 additions & 1 deletion pkg/operator/starter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,6 @@ func RunOperator(ctx context.Context, controllerContext *controllercmd.Controlle
"etcd/sa.yaml",
"etcd/svc.yaml",
"etcd/sm.yaml",
"etcd/minimal-sm.yaml",
"etcd/prometheus-role.yaml",
"etcd/prometheus-rolebinding.yaml",
"etcd/backups-sa.yaml",
Expand Down