-
Notifications
You must be signed in to change notification settings - Fork 221
OCPBUGS-44056: Remove unneeded VNet permissions from Azure CredentialsRequest #1307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@fahlmant: This pull request references Jira Issue OCPBUGS-44056, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/test e2e-azure-manual-oidc |
@sunzhaohua2 Could you please assign one of the QE team to pre-merge test this PR once openshift/machine-api-provider-azure#122 lands in a nightly |
/retest-required |
Sure, I will test this pr. |
/retest-required |
/test e2e-vsphere-ovn-upgrade |
@fahlmant: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Run regression testing for mapi cases, no issue. |
@fahlmant: This pull request references Jira Issue OCPBUGS-44056, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@fahlmant: Jira Issue OCPBUGS-44056: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-44056 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] Distgit: ose-machine-api-operator |
/cherry-pick release-4.17 |
@theobarberbany: new pull request created: #1337 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
https://issues.redhat.com/browse/OCPBUGS-44056
openshift/machine-api-provider-azure#122
Follow up on above PR. The code to managed VNet is being removed from the operator as it is unused, so also removing the matching permissions from the CredentialRequest