OCPBUGS-44056: Remove unused vnet package #122
Conversation
|
/retest |
|
/test e2e-azure-operator |
|
@sdodson @JoelSpeed could have someone look at this PR? |
|
@fahlmant: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm @fahlmant if there's no Jira issue created for this, you can prefix the PR title with |
fahlmant
changed the title
|
@nrb added, what's the best way to get prow to see that without running all the tests again? |
JoelSpeed
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@fahlmant: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
It needed Is there no jira related to this? I assume removing this then also results in a PR to remove the permissions from the credentials request, is that also coming? |
|
I can create a jira. This came up during review of required permissions as we implement MiWi for ARO. I can also make a PR for the CredentialsRequest, where is that defined? I don't see that in this repo but I could be easily missing it |
fahlmant
changed the title
openshift-ci-robot
added
the
jira/invalid-bug
|
@fahlmant: This pull request references Jira Issue OCPBUGS-44056, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
jira/valid-bug
|
@fahlmant: This pull request references Jira Issue OCPBUGS-44056, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@JoelSpeed created jira and created CredentialsRequest update PR openshift/machine-api-operator#1307 |
|
/test e2e-azure-manual-oidc |
|
@fahlmant: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@fahlmant: Jira Issue OCPBUGS-44056: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-44056 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-machine-api-provider-azure |
|
/cherry-pick release-4.17 |
|
@theobarberbany: new pull request created: #130 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The virtualnetworks package is not used anywhere directly in MAPI. This PR removes the package and the unnecessary requirements for Azure permissions to perform highly sensitive actions, specifically the ability to delete vnets. MAPI doesn't manage the vnet that a given cluster is installed in, so should not have the ability to delete the vnet or other vnets in the Azure subscription/resource group.
Related CredentialsRequest update: openshift/machine-api-operator#1307