Skip to content

[release-4.17] OCPBUGS-62909: Fix job success logic #3446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release-4.17
Choose a base branch
from
Open

[release-4.17] OCPBUGS-62909: Fix job success logic #3446

wants to merge 1 commit into from

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Oct 9, 2025

This is an automated cherry-pick of #3377

/assign sebsoto

/cherrypick release-4.16

@sebsoto
Fix job success logic
43ac108 
We are reporting jobs as failed if a pod within the job failed. This is
incorrect logic, as a single pod failing is not a failure state for the
entire job. The job will keep creating pods until a success is seen.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 9, 2025
Merged
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 9, 2025

@openshift-cherrypick-robot: Jira Issue OCPBUGS-62480 has been cloned as Jira Issue OCPBUGS-62909. Will retitle bug to link to clone.
/retitle [release-4.17] OCPBUGS-62909: Fix job success logic

In response to this:

This is an automated cherry-pick of #3377

/assign sebsoto

/cherrypick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.17] OCPBUGS-62480: Fix job success logic [release-4.17] OCPBUGS-62909: Fix job success logic Oct 9, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 9, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 9, 2025

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-62909, which is invalid:

  • expected dependent Jira Issue OCPBUGS-62480 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #3377

/assign sebsoto

/cherrypick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sebsoto
Copy link
Contributor

sebsoto commented Oct 9, 2025

/approve

@sebsoto
Copy link
Contributor

sebsoto commented Oct 9, 2025

/lgtm

@sebsoto sebsoto removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 9, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, sebsoto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2025
@jrvaldes
Copy link
Contributor

jrvaldes commented Oct 9, 2025

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 9, 2025

/retest-required

Remaining retests: 0 against base HEAD 9f529fa and 2 for PR HEAD 43ac108 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 9, 2025

/retest-required

Remaining retests: 0 against base HEAD 46d9601 and 1 for PR HEAD 43ac108 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 18, 2025

/retest-required

Remaining retests: 0 against base HEAD aa3adf1 and 0 for PR HEAD 43ac108 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 18, 2025

/hold

Revision 43ac108 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 18, 2025
@jrvaldes
Copy link
Contributor

jrvaldes commented Oct 21, 2025

/retest-required

@jrvaldes
Copy link
Contributor

jrvaldes commented Oct 21, 2025

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 21, 2025

/retest-required

Remaining retests: 0 against base HEAD ddf449b and 2 for PR HEAD 43ac108 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 23, 2025

/retest-required

Remaining retests: 0 against base HEAD 68adc85 and 1 for PR HEAD 43ac108 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 23, 2025

/retest-required

Remaining retests: 0 against base HEAD 9701cee and 0 for PR HEAD 43ac108 in total

@jrvaldes
Copy link
Contributor

jrvaldes commented Oct 23, 2025

/override ci/prow/platform-none-vsphere-e2e-operator

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2025

@jrvaldes: Overrode contexts on behalf of jrvaldes: ci/prow/platform-none-vsphere-e2e-operator

In response to this:

/override ci/prow/platform-none-vsphere-e2e-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jrvaldes
Copy link
Contributor

jrvaldes commented Oct 23, 2025

aws-e2e-operator is failing with

2025/10/23 15:29:20 failed to change ci-op-zq30nln2-1d318-vtskc-e2e-9sm8s default shell to Powershell
    create_test.go:314: 
        	Error Trace:	/go/src/github.com/openshift/windows-machine-config-operator/test/e2e/create_test.go:314
        	Error:      	Received unexpected error:
        	            	unable to change default shell of machine ci-op-zq30nln2-1d318-vtskc-e2e-9sm8s: timed out waiting for the condition
        	Test:       	TestWMCO/create/Creation/ConfigMap_controller
        	Messages:   	error provisioning BYOH ConfigMap with MachineSets

https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_windows-machine-config-operator/3446/pull-ci-openshift-windows-machine-config-operator-release-4.17-aws-e2e-operator/1981347174574723072

https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_windows-machine-config-operator/3446/pull-ci-openshift-windows-machine-config-operator-release-4.17-aws-e2e-operator/1980721395520245760

https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_windows-machine-config-operator/3446/pull-ci-openshift-windows-machine-config-operator-release-4.17-aws-e2e-operator/1980678272417009664

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2025

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gcp-e2e-operator 43ac108 link true /test gcp-e2e-operator
ci/prow/aws-e2e-operator 43ac108 link true /test aws-e2e-operator
ci/prow/vsphere-disconnected-e2e-operator 43ac108 link true /test vsphere-disconnected-e2e-operator
ci/prow/azure-e2e-upgrade 43ac108 link true /test azure-e2e-upgrade
ci/prow/platform-none-vsphere-e2e-operator 43ac108 link true /test platform-none-vsphere-e2e-operator
ci/prow/vsphere-e2e-operator 43ac108 link true /test vsphere-e2e-operator
ci/prow/nutanix-e2e-operator 43ac108 link true /test nutanix-e2e-operator
ci/prow/vsphere-proxy-e2e-operator 43ac108 link true /test vsphere-proxy-e2e-operator
ci/prow/azure-e2e-operator 43ac108 link true /test azure-e2e-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 23, 2025

/hold

Revision 43ac108 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mansikulkarni96 mansikulkarni96 Awaiting requested review from mansikulkarni96

@sebsoto sebsoto Awaiting requested review from sebsoto

Assignees

@sebsoto sebsoto

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@openshift-cherrypick-robot @openshift-ci-robot @sebsoto @jrvaldes