-
Notifications
You must be signed in to change notification settings - Fork 139
Add new baremetal job to run minor update #3470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6473a57 to
cb98d78
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5ba10f3919104fd2a79357d338bebd6a ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 51m 28s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e18adbea8a1c477fb148770e87b080cb ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 41m 10s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5c7b87fe3a494f5bb5e3ee1ef9310655 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 48m 21s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bf766197804241c6afd86794d9aabf2e ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 50m 46s |
f5ed54b to
71074d3
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f911fd1b4465476f9d7795e3f0e158fc ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 24m 05s |
90457b4 to
a94e475
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4878bc7a780d4f8d8da193530ca5d41a ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 49m 43s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3630cd8b93324a2a974c3679cbfc22fe Warning: |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f4adcbbf55024c8ab5dbe80c11f618fa ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 54m 47s |
|
recheck |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3074701fac4145edbb38cb5a55a7da08 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 51m 03s |
107547f to
e4bbbba
Compare
|
This change depends on a change that failed to merge. Change openstack-k8s-operators/edpm-ansible#1054 is needed. |
|
recheck |
|
This change depends on a change that failed to merge. Change openstack-k8s-operators/edpm-ansible#1054 is needed. |
|
recheck |
| hosts: "{{ cifmw_zuul_target_host | default('all') }}" | ||
| gather_facts: true | ||
| tasks: | ||
| - name: Filter out host if needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(non-blocking) question: Why do we need this filtering out? Is it because a zuul contraint?
Is this not already done in L3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's added in other existing playbooks with 49c4916, so I continued using it.
| ansible.builtin.command: | ||
| chdir: "{{ ansible_user_dir }}/src/github.com/openstack-k8s-operators/ci-framework" | ||
| cmd: >- | ||
| ansible-playbook deploy-edpm.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danpawlik are we OK by executing here ansible-playbook commands?
I was thinking of spliting the zuul job in three:
run:
- ci/playbooks/edpm_baremetal_update/prepare.yml
- deploy-edpm.yml
- ci/playbooks/edpm_baremetal_update/update.yml
so basically, moving the run to a prepare playbook, until the execution of deploy-edpm and then going by running the update.
WDYT @danpawlik ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we run ansible-playbook commands in other playbooks https://github.com/openstack-k8s-operators/ci-framework/blob/main/ci/playbooks/edpm_baremetal_deployment/run.yml#L60 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, we can't use deploy_edpm.yml as is, as we don't want to update container images from content provider in openstackversion during deploy. It has to be done after the deploy and midway through update.
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/66bbc059db21482581fd7a036f7385bf ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 20m 52s |
370f098 to
54710b4
Compare
Adds a new baremetal job to test minor update with upstream github content. This will currently test from fr3->main(with PR). Signed-off-by: rabi <[email protected]>
Adds a new baremetal job to run minor update.
Depends-On: openstack-k8s-operators/install_yamls#1109
Depends-On: openstack-k8s-operators/edpm-ansible#1054