Take commit msg from SHA-1 to verify pr prefix; don't count Signed-Off-By #3479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holser
previously approved these changes
Nov 12, 2025
danpawlik
force-pushed
the
improve-prefix-role
branch
from
f28e2bd to
ccb163f
Compare
…f-By Commit fixes issues: - git body count characters "fits" for requirements when "Signed-Off-By" was set - take commit message from commit SHA-1 instead of compute it in the script in Github workflows Signed-off-by: Daniel Pawlik <[email protected]>
danpawlik
force-pushed
the
improve-prefix-role
branch
from
ccb163f to
627cafa
Compare
danpawlik
changed the title
dasm
approved these changes
Nov 12, 2025
michburk
approved these changes
Nov 12, 2025
rebtoor
reviewed
Nov 12, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
danpawlik
merged commit 1104f25
into
openstack-k8s-operators:main
10 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…f-By
Commit fixes issues: