Add support for custom Barbican images and parameterized HSM secrets #1183
Conversation
mauricioharley
force-pushed
the
barbican-hsm-custom-images-support
branch
from
bc5941f to
3f7277b
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/779a6be761b541e3a19a1b3710c0df40 ✔️ noop SUCCESS in 0s |
|
recheck |
|
This PR is stale because it has been for over 15 days with no activity. |
jistr
left a comment
jistr
left a comment
There was a problem hiding this comment.
I think my previous review is still relevant: #1059 (review)
|
Thank you, lgtm :) |
|
@jistr, is there a merge bot in this repository? :-) |
|
There should be at least 2 reviews (unless the patch is trivial), then we merge. |
Extend the existing barbican_adoption role with minimal HSM support for Proteccio integration. Fixes: OSPRH-18981 Signed-off-by: Mauricio Harley <[email protected]>
This change adds support for: - Custom Barbican API and Worker container images via barbican_custom_api_image and barbican_custom_worker_image variables - Parameterized HSM secret names via proteccio_login_secret_name and proteccio_client_data_secret_name variables This enables adoption scenarios where Barbican requires custom images with HSM client libraries (e.g., Proteccio) installed. Signed-off-by: Mauricio Harley <[email protected]>
This commit addresses some comments by a reviewer on an analogous PR (openstack-k8s-operators#1059 (review)). Signed-off-by: Mauricio Harley <[email protected]>
mauricioharley
force-pushed
the
barbican-hsm-custom-images-support
branch
from
a126db2 to
51a7db2
Compare
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
2 participants
This PR adds support for custom Barbican container images and parameterized
HSM secret names in the adoption process.
Changes
barbican_adoption/defaults/main.yaml: Parameterized
loginSecretandclientDataSecretnames in thebarbican_hsm_patchtemplate to allowcustom secret names via variables.
backend_services/tasks/main.yaml: Added two new tasks to patch
OpenStackVersion CR with custom Barbican images when
barbican_custom_api_imageorbarbican_custom_worker_imageare defined.Jira: OSPRH-20112