Skip to content

Conversation

@dudy-duce
Copy link

@dudy-duce dudy-duce commented Nov 1, 2025

Users can override this list to customize collectors.

Why this approach

  • Keeping the command as a list of strings matches how the template renders the JSON command array.
  • Using to_json ensures any characters (like backslashes or parentheses) are properly escaped in JSON.
  • Defaulting the variable to the current options preserves existing behavior and provides an easy override point.

Edge cases considered

  • If a user overrides the variable with a single string or wrongly typed value — best practice is to override as a YAML list of strings (examples below). The template assumes a list; providing any other type may render incorrectly.
  • The TLS flag still prepends the --web.config.file entry when tls_cert_exists is true, so that behavior is unchanged.

Resolve issue.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 1, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dudy-duce
Once this PR has been reviewed and has the lgtm label, please assign vyzigold for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 1, 2025

Hi @dudy-duce. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dudy-duce dudy-duce force-pushed the node-exporter-command branch from 4cb1be2 to 647ece2 Compare November 1, 2025 11:18
Users can override this list to customize collectors.
The TLS flag still prepends the --web.config.file entry when tls_cert_exists is true, so that behavior is unchanged.

Signed-off-by: dudy <[email protected]>
@dudy-duce dudy-duce force-pushed the node-exporter-command branch from 647ece2 to e240abe Compare November 1, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFE] node-exporter command

1 participant