Skip to content

feat: create a variable for node exporter command #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+32 −18
Open

feat: create a variable for node exporter command #1055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions roles/edpm_telemetry/defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,27 @@ edpm_telemetry_image_download_retries: "{{ edpm_download_retries | default(5) }}
# list of tripleo telemetry services to stop during EDPM adoption
edpm_telemetry_old_tripleo_compute_sevices:
- tripleo_ceilometer_agent_compute.service

# Command options for node_exporter. This can be overridden to enable/disable collectors
# Keep this as a list of strings which will be rendered into the container JSON command.
edpm_telemetry_node_exporter_cmd:
- "--web.disable-exporter-metrics"
- "--collector.systemd"
- "--collector.systemd.unit-include=(edpm_.*|ovs.*|openvswitch|virt.*|rsyslog)\\.service"
- "--no-collector.dmi"
- "--no-collector.entropy"
- "--no-collector.thermal_zone"
- "--no-collector.time"
- "--no-collector.timex"
- "--no-collector.uname"
- "--no-collector.stat"
- "--no-collector.hwmon"
- "--no-collector.os"
- "--no-collector.selinux"
- "--no-collector.textfile"
- "--no-collector.powersupplyclass"
- "--no-collector.pressure"
- "--no-collector.rapl"
# Instruction for distribution of container health check scripts
edpm_telemetry_healthcheck_sources:
ceilometer_agent_compute: ceilometer_agent
Expand Down
7 changes: 7 additions & 0 deletions roles/edpm_telemetry/meta/argument_specs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,3 +66,10 @@ argument_specs:
type: list
required: true
description: "List of exporters to be deployed in the compute node"
edpm_telemetry_node_exporter_cmd:
type: list
required: false
description: >
List of command-line options passed to the node_exporter container.
Each item should be a single string representing one option/argument.
Override this list to enable/disable collectors or add extra flags.
22 changes: 4 additions & 18 deletions roles/edpm_telemetry/templates/node_exporter.json.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,25 +7,11 @@
"ports": ["9100:9100"],
"command": [
{% if tls_cert_exists|bool %}
"--web.config.file=/etc/node_exporter/node_exporter.yaml",
"--web.config.file=/etc/node_exporter/node_exporter.yaml",
{% endif %}
"--web.disable-exporter-metrics",
"--collector.systemd",
"--collector.systemd.unit-include=(edpm_.*|ovs.*|openvswitch|virt.*|rsyslog)\\.service",
"--no-collector.dmi",
"--no-collector.entropy",
"--no-collector.thermal_zone",
"--no-collector.time",
"--no-collector.timex",
"--no-collector.uname",
"--no-collector.stat",
"--no-collector.hwmon",
"--no-collector.os",
"--no-collector.selinux",
"--no-collector.textfile",
"--no-collector.powersupplyclass",
"--no-collector.pressure",
"--no-collector.rapl"
{% for arg in edpm_telemetry_node_exporter_cmd %}
{{ arg | to_json }}{% if not loop.last %},{% endif %}
{% endfor %}
],
"net": "host",
"environment": {
Expand Down