Skip to content

Move queueType default selection to infra-operator #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move queueType default selection to infra-operator #485

wants to merge 1 commit into from
+111 −49

Conversation

@lmiccini
Copy link
Contributor

@lmiccini lmiccini commented Oct 21, 2025 •
edited
Loading 

This commit implements the following:

- removes "Mirrored" as default value for queueType
- adds logic to the webhook so that when queueType=nil this is instead
  set to "Quorum"

This would allow us to:

- set a sane default for new clusters, unless the user decides
  otherwise
- preserve existing clusters where queueType=Mirrored is configured
- orchestrate migration from Mirrored to Quorum by adding logic that
  would react to the change of value

Jira: https://issues.redhat.com/browse/OSPRH-21039

@openshift-ci openshift-ci bot requested review from abays and dprince October 21, 2025 07:19
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lmiccini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Oct 21, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0e5935ddc2d24f278f3af290a2e30319

❌ openstack-k8s-operators-content-provider FAILURE in 13m 22s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@lmiccini
Copy link
Contributor Author

lmiccini commented Oct 21, 2025

recheck

@lmiccini
Copy link
Contributor Author

lmiccini commented Oct 21, 2025

/test infra-operator-build-deploy-kuttl

@lmiccini
Move queueType default selection to infra-operator
50b88c3 
This commit implements the following:

- switches the default queueType value to nil (instead of Mirrored)
- adds logic to the webhook so that when queueType=nil this is instead
  set to "Quorum"

This would allow us to:

- set a sane default for new clusters, unless the user decides
  otherwise
- preserve existing clusters where queueType=Mirrored is configured
- orchestrate migration from Mirrored to Quorum by adding logic that
  would react to the change of value

Jira: https://issues.redhat.com/browse/OSPRH-21039
@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Nov 13, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b7de5e6043e74e229be82f5e765f28d0

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 02m 25s
❌ podified-multinode-edpm-deployment-crc FAILURE in 35m 43s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 39m 58s

@lmiccini
Copy link
Contributor Author

lmiccini commented Nov 14, 2025

recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abays abays Awaiting requested review from abays

@dprince dprince Awaiting requested review from dprince

Assignees

No one assigned

Labels

approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lmiccini