Skip to content

Get secrets to hash for api and conductor pods <JIRA: OSPRH-10696>#570

Merged
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
mumesan:get_secrets_to_hash_OSPRH-10696
Jul 3, 2025
Merged

Get secrets to hash for api and conductor pods <JIRA: OSPRH-10696>#570
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
mumesan:get_secrets_to_hash_OSPRH-10696

Conversation

@mumesan
Copy link
Copy Markdown
Contributor

@mumesan mumesan commented Jul 3, 2025

In commit: 95b3db1 there was a switch
from using ConfigMap to using secret.

-       return configmap.EnsureConfigMaps(ctx, h, instance, cms, envVars)
+       return secret.EnsureSecrets(ctx, h, instance, cms, envVars)

This PR makes it so that the hash for secrets gets added to configMapVars so that changes to the configMap is detected and a reconcile takes place.

Jira: OSPRH-10696

@openshift-ci openshift-ci bot requested review from steveb and stuggi July 3, 2025 11:10
@mumesan mumesan changed the title Get secrets to hash for api and conductor pods <JIRA: OSPRH-10696> [WIP] Get secrets to hash for api and conductor pods <JIRA: OSPRH-10696> Jul 3, 2025
@mumesan mumesan force-pushed the get_secrets_to_hash_OSPRH-10696 branch 2 times, most recently from 0403055 to d87b0aa Compare July 3, 2025 12:16
@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9a71a878704343998bd956d89124bc24

✔️ noop SUCCESS in 0s
openstack-k8s-operators-content-provider FAILURE in 19m 41s
⚠️ podified-multinode-ironic-deployment SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@mumesan mumesan force-pushed the get_secrets_to_hash_OSPRH-10696 branch from d87b0aa to acfb913 Compare July 3, 2025 12:52
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jul 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hjensas, mumesan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jul 3, 2025
@hjensas hjensas changed the title [WIP] Get secrets to hash for api and conductor pods <JIRA: OSPRH-10696> Get secrets to hash for api and conductor pods <JIRA: OSPRH-10696> Jul 3, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit bba68ca into openstack-k8s-operators:main Jul 3, 2025
7 checks passed
hjensas pushed a commit to hjensas/ironic-operator that referenced this pull request Jul 22, 2025
…ts_to_hash_OSPRH-10696

Get secrets to hash for api and conductor pods <JIRA: OSPRH-10696>
mumesan pushed a commit to mumesan/ironic-operator that referenced this pull request Jul 22, 2025
…ts_to_hash_OSPRH-10696

Get secrets to hash for api and conductor pods <JIRA: OSPRH-10696>
mumesan pushed a commit to mumesan/ironic-operator that referenced this pull request Jul 22, 2025
…ts_to_hash_OSPRH-10696

Get secrets to hash for api and conductor pods <JIRA: OSPRH-10696>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants