Skip to content

Remove TODO comments from conductor and inspector <JIRA: OSPRH-18882>#636

Merged
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
mumesan:OSPRH-18882
Oct 23, 2025
Merged

Remove TODO comments from conductor and inspector <JIRA: OSPRH-18882>#636
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
mumesan:OSPRH-18882

Conversation

@mumesan
Copy link
Copy Markdown
Contributor

@mumesan mumesan commented Oct 23, 2025

Describe your changes

These TODO comments will not be implemented and can be removed.

Jira Ticket Link

Jira: OSPRH-18882

Checklist before requesting a review

  • I have performed a self-review of my code and confirmed it passes tests
  • Performed pre-commit run --all
  • Tested operator image in a test/dev environment. It can be CRC via install_yamls or a hotstack instance (optional)
  • Verified that no failures present in logs(optional):
    • ironic-operator-build-deploy-kuttl
    • podified-multinode-ironic-deployment

@openshift-ci openshift-ci bot requested review from juliakreger and stuggi October 23, 2025 14:36
Copy link
Copy Markdown
Collaborator

@steveb steveb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Oct 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mumesan, steveb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 87e9d60 into openstack-k8s-operators:main Oct 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants