Add observabilityclient config to env vars #643

vyzigold · 2024-01-30T10:12:56Z

This adds the needed variables for the observabilityclient to work. Observabilityclient allows to execute openstack metric command for interacting with prometheus deployed as part of telemetry MetricStorage by the telemetry-operator.

I should note that the observabilityclient currently isn't available in the openstackclient container image, so the openstack metric commands aren't available at the moment without manually installing it. But the PR itself doesn't require observabilityclient installed on the container.

Depends-On: #641

vyzigold · 2024-01-30T10:17:07Z

Work on readding observabilityclient to the image is ongoing here: openstack-k8s-operators/tcib#122

softwarefactory-project-zuul · 2024-01-30T10:27:51Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/965b7a22e8ca443faf729ee8017db007

❌ openstack-k8s-operators-content-provider FAILURE in 12m 51s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

vyzigold · 2024-01-30T17:24:38Z

I think the issue might be, that the added telemetry-operator dependency is too new and the operators in go.mod need to be updated first. I added a depends-on on that PR. I'll take a look at this once that's merged.

softwarefactory-project-zuul · 2024-02-05T06:48:56Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/af9a772b5ace4ae9804bd25f9549b741

❌ openstack-k8s-operators-content-provider FAILURE in 13m 19s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

jlarriba · 2024-02-06T08:45:51Z

/lgtm

hack/pin-bundle-images.sh

vyzigold · 2024-02-07T09:09:39Z

I rebased on top of main

softwarefactory-project-zuul · 2024-02-07T10:58:42Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/31fc2a45998f45c087494b5f337f006f

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 47m 55s
❌ podified-multinode-edpm-deployment-crc RETRY_LIMIT in 12m 10s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 17m 01s
❌ cifmw-data-plane-adoption-osp-17-to-extracted-crc RETRY_LIMIT in 11m 47s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 31m 57s

vyzigold · 2024-02-07T14:07:47Z

recheck

Failed to add subports to trunk 'f738f107-af28-4a9f-a0c0-773c84b5392f': ConflictException: 409: Client Error for url: https://network.rdo.mtl2.vexxhost.net/v2.0/trunks/f738f107-af28-4a9f-a0c0-773c84b5392f/add_subports, Port 91b881f3-dce8-44c8-b5fc-fa43db8f9083 is in use by another trunk.

ConflictException: 409: Client Error for url: https://compute.rdo.mtl2.vexxhost.net/v2.1/servers/4f95266a-ae23-4449-b865-04ab0b1c68b1/os-interface, Port 512b2651-37b3-4009-b5b4-c3df39d5b916 is still in use.

softwarefactory-project-zuul · 2024-02-07T16:30:44Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/037b28903b28413ca2ca5860a43439fb

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 21m 13s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 05m 36s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 12m 42s
✔️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 04m 51s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 21m 40s

vyzigold · 2024-02-07T21:11:48Z

recheck

ERROR! Unexpected Exception, this is probably a bug: [Errno 117] Structure needs cleaning: 'refs'

softwarefactory-project-zuul · 2024-02-07T23:38:09Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/4e8523b0418e4053b3a7e1e2989407cd

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 24m 35s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 04m 49s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 1m 54s
✔️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 06m 38s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 31m 52s

vyzigold · 2024-02-12T06:55:36Z

recheck

vyzigold · 2024-02-12T15:18:43Z

recheck

softwarefactory-project-zuul · 2024-02-12T17:29:51Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/a6304f875c7646eabab0cf9524456331

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 10m 17s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 50m 45s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 55m 00s
❌ cifmw-data-plane-adoption-osp-17-to-extracted-crc RETRY_LIMIT in 44m 08s
❌ openstack-operator-tempest-multinode FAILURE in 1h 05m 38s

vyzigold · 2024-02-13T16:46:43Z

recheck
Different tempest scenarios failed this time:

tempest.scenario.test_server_volume_attachment.TestServerVolumeAttachScenarioOldVersion
tempest.scenario.test_server_volume_attachment.TestServerVolumeAttachmentScenario

softwarefactory-project-zuul · 2024-02-13T19:20:12Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/9396756e4e3048bea1284185b19c8c03

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 31m 52s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 03m 29s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 14m 43s
✔️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 08m 54s
❌ openstack-operator-tempest-multinode FAILURE in 1h 23m 40s

vyzigold · 2024-02-14T06:40:54Z

recheck

softwarefactory-project-zuul · 2024-02-14T09:09:06Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/1bf7e2237071466aacabd1a725365a7e

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 26m 49s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 07m 11s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 09m 05s
✔️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 11m 23s
❌ openstack-operator-tempest-multinode FAILURE in 1h 17m 32s

vyzigold · 2024-02-20T08:07:54Z

I squashed the commits, rebased on top of main and used the latest telemetry-operator api. This allowed me to drop the dependency on the telemetry-operator.

softwarefactory-project-zuul · 2024-02-20T09:28:03Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/1f37ab3c04f64ebbb57c3c1319136449

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 21m 43s
❌ podified-multinode-edpm-deployment-crc FAILURE in 59m 43s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 02m 20s
❌ cifmw-data-plane-adoption-osp-17-to-extracted-crc RETRY_LIMIT in 1h 05m 05s
❌ openstack-operator-tempest-multinode FAILURE in 1h 02m 49s

vyzigold · 2024-02-20T15:41:14Z

recheck

softwarefactory-project-zuul · 2024-02-20T17:05:00Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/455e7f60a7a54326b8b7e3d509a82211

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 23m 14s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 00m 30s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 06m 30s
❌ cifmw-data-plane-adoption-osp-17-to-extracted-crc RETRY_LIMIT in 1h 06m 34s
❌ openstack-operator-tempest-multinode FAILURE in 1h 08m 05s

vyzigold · 2024-02-21T05:55:28Z

recheck
memchached is trying to use an non-existing image. I saw some tests succeed this morning, so I hope the issue is fixed.

  Normal   Pulling         30m (x4 over 31m)    kubelet            Pulling image "quay.io/podified-antelope-centos9/openstack-memcached@sha256:2aa527adcae69681592973e21d18e81a866627f43aed048822defcaf04949582"
  Warning  Failed          30m (x4 over 31m)    kubelet            Failed to pull image "quay.io/podified-antelope-centos9/openstack-memcached@sha256:2aa527adcae69681592973e21d18e81a866627f43aed048822defcaf04949582": rpc error: code = Unknown desc = reading manifest sha256:2aa527adcae69681592973e21d18e81a866627f43aed048822defcaf04949582 in quay.io/podified-antelope-centos9/openstack-memcached: manifest unknown
  Warning  Failed          30m (x4 over 31m)    kubelet            Error: ErrImagePull
  Warning  Failed          29m (x6 over 31m)    kubelet            Error: ImagePullBackOff

softwarefactory-project-zuul · 2024-02-21T07:19:02Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/762ee317f32745e3aa9a9c1b8912b4cf

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 22m 26s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 00m 07s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 04m 42s
❌ cifmw-data-plane-adoption-osp-17-to-extracted-crc RETRY_LIMIT in 1h 04m 17s
❌ openstack-operator-tempest-multinode FAILURE in 1h 03m 41s

softwarefactory-project-zuul · 2024-02-21T08:33:12Z

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/openstack-operator for 643,54aa7fab8055a388db92b300f90467c36043d186

abays

/lgtm

openshift-ci · 2024-02-21T12:37:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, jlarriba, vyzigold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [abays]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…le_defaults Fix roles default vars to correctly use edpm_service_name

openshift-ci bot requested review from dprince and lewisdenny January 30, 2024 10:13

vyzigold requested a review from paramite January 30, 2024 10:16

vyzigold mentioned this pull request Jan 30, 2024

[go.mod]Bump from v0.3.0 to pseudoversion openstack-k8s-operators/telemetry-operator#287

Closed

openshift-merge-robot added needs-rebase and removed needs-rebase labels Feb 2, 2024

vyzigold requested a review from jlarriba February 5, 2024 14:33

jlarriba approved these changes Feb 6, 2024

View reviewed changes

openshift-ci bot assigned jlarriba Feb 6, 2024

openshift-ci bot added the lgtm label Feb 6, 2024

jlarriba requested a review from abays February 6, 2024 08:46

abays reviewed Feb 6, 2024

View reviewed changes

hack/pin-bundle-images.sh Outdated Show resolved Hide resolved

openshift-merge-robot added the needs-rebase label Feb 6, 2024

vyzigold force-pushed the add-observabilityclient-config branch from 1fa69b8 to 5e2f934 Compare February 7, 2024 09:09

openshift-ci bot removed the lgtm label Feb 7, 2024

openshift-merge-robot removed the needs-rebase label Feb 7, 2024

stuggi mentioned this pull request Feb 14, 2024

[tempest] cinder-volume is not configured add more tests to skip #666

Merged

openshift-merge-robot added the needs-rebase label Feb 16, 2024

vyzigold mentioned this pull request Feb 19, 2024

Move metricstorage consts to api openstack-k8s-operators/telemetry-operator#309

Merged

vyzigold force-pushed the add-observabilityclient-config branch from 5e2f934 to 2a33139 Compare February 20, 2024 08:05

openshift-merge-robot removed the needs-rebase label Feb 20, 2024

openshift-merge-robot added the needs-rebase label Feb 21, 2024

vyzigold added 2 commits February 21, 2024 04:20

Add observabilityclient config to env vars

61108e0

Update infra-operator

d4fe388

vyzigold force-pushed the add-observabilityclient-config branch from 54aa7fa to d4fe388 Compare February 21, 2024 09:25

openshift-merge-robot removed the needs-rebase label Feb 21, 2024

abays approved these changes Feb 21, 2024

View reviewed changes

openshift-ci bot assigned abays Feb 21, 2024

openshift-ci bot added the lgtm label Feb 21, 2024

openshift-ci bot added the approved label Feb 21, 2024

openshift-merge-bot bot merged commit a136dbd into openstack-k8s-operators:main Feb 21, 2024

This was referenced Feb 21, 2024

[zuul] Add telemetry-operator-multinode-autoscaling-tempest job openstack-k8s-operators/telemetry-operator#284

Merged

[tlse] tls support for telemetry aodh openstack-k8s-operators/telemetry-operator#310

Merged

cjeanner pushed a commit to cjeanner/openstack-operator that referenced this pull request Apr 9, 2025

Merge pull request openstack-k8s-operators#643 from karelyatin/fix_ro…

071c0e7

…le_defaults Fix roles default vars to correctly use edpm_service_name

Add observabilityclient config to env vars #643

Add observabilityclient config to env vars #643

Uh oh!

Conversation

vyzigold commented Jan 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vyzigold commented Jan 30, 2024

Uh oh!

softwarefactory-project-zuul bot commented Jan 30, 2024

Uh oh!

vyzigold commented Jan 30, 2024

Uh oh!

softwarefactory-project-zuul bot commented Feb 5, 2024

Uh oh!

jlarriba commented Feb 6, 2024

Uh oh!

Uh oh!

vyzigold commented Feb 7, 2024

Uh oh!

softwarefactory-project-zuul bot commented Feb 7, 2024

Uh oh!

vyzigold commented Feb 7, 2024

Uh oh!

softwarefactory-project-zuul bot commented Feb 7, 2024

Uh oh!

vyzigold commented Feb 7, 2024

Uh oh!

softwarefactory-project-zuul bot commented Feb 7, 2024

Uh oh!

vyzigold commented Feb 12, 2024

Uh oh!

vyzigold commented Feb 12, 2024

Uh oh!

softwarefactory-project-zuul bot commented Feb 12, 2024

Uh oh!

vyzigold commented Feb 13, 2024

Uh oh!

softwarefactory-project-zuul bot commented Feb 13, 2024

Uh oh!

vyzigold commented Feb 14, 2024

Uh oh!

softwarefactory-project-zuul bot commented Feb 14, 2024

Uh oh!

vyzigold commented Feb 20, 2024

Uh oh!

softwarefactory-project-zuul bot commented Feb 20, 2024

Uh oh!

vyzigold commented Feb 20, 2024

Uh oh!

softwarefactory-project-zuul bot commented Feb 20, 2024

Uh oh!

vyzigold commented Feb 21, 2024

Uh oh!

softwarefactory-project-zuul bot commented Feb 21, 2024

Uh oh!

softwarefactory-project-zuul bot commented Feb 21, 2024

Uh oh!

abays left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Feb 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vyzigold commented Jan 30, 2024 •

edited

Loading