fix(sdk): Fix new API not setting nano attributes #679
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @dmihalcik-virtru, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request resolves a critical bug in the SDK's Collection class, ensuring that nano attributes are correctly applied during the initialization of new instances. This fix is vital for the proper functioning of the new API, guaranteeing that data attributes are consistently set as intended.
Highlights
- Bug Fix: Corrected an issue in the
Collectionclass constructor withinlib/src/opentdf.tswherenano attributeswere not being properly set on the internal client. The fix ensures thatthis.client.dataAttributesare initialized from theopts.attributesparameter.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request fixes a bug where data attributes were not being set for NanoTDF creation using the new API. The change is straightforward and effective. A suggestion has been made to improve code quality and maintainability by using the nullish coalescing operator.
| @@ -777,6 +777,7 @@ class Collection { | |||
| maxKeyIterations: opts.maxKeyIterations, | |||
| platformUrl: opts.platformUrl, | |||
| }); | |||
| this.client.dataAttributes = opts.attributes || []; | |||
There was a problem hiding this comment.
Consider using the nullish coalescing operator (??) instead of the logical OR (||) for providing default values. ?? only provides the default for null or undefined, avoiding potential issues with other falsy values (like '' or 0). While both work here due to the type of opts.attributes, using ?? is a good practice for robustness and clarity.
| this.client.dataAttributes = opts.attributes || []; | |
| this.client.dataAttributes = opts.attributes ?? []; |
|
|
/backport |
|
Successfully created backport PR for |
(cherry picked from commit f0d9719)
(cherry picked from commit f0d9719)
No description provided.