Skip to content

fix(sdk): Fix new API not setting nano attributes #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025
Merged

fix(sdk): Fix new API not setting nano attributes #679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/src/opentdf.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,6 +777,7 @@ class Collection {
maxKeyIterations: opts.maxKeyIterations,
platformUrl: opts.platformUrl,
});
this.client.dataAttributes = opts.attributes || [];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider using the nullish coalescing operator (??) instead of the logical OR (||) for providing default values. ?? only provides the default for null or undefined, avoiding potential issues with other falsy values (like '' or 0). While both work here due to the type of opts.attributes, using ?? is a good practice for robustness and clarity.

Suggested change
this.client.dataAttributes = opts.attributes || [];
this.client.dataAttributes = opts.attributes ?? [];

}

/** Encrypts a source into a NanoTDF stream. */
Expand Down
Loading