do not update (singular) BlockEmission for every subnet #1987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fetching Tao block emission
JohnReedV
added
the
skip-cargo-audit
open-junius
reviewed
Aug 28, 2025
| Self::get_block_emission_for_issuance(Self::get_total_issuance().into()); | ||
| let block_emission_u64: u64 = block_emission.unwrap_or(0); | ||
| if BlockEmission::<T>::get() != block_emission_u64 { | ||
| BlockEmission::<T>::put(block_emission_u64); |
There was a problem hiding this comment.
it is not a good idea to update anything in a get method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do not update (singular) BlockEmission for every subnet but only on fetching Tao block emission
Description
BlockEmission is updated in a utility function, which is very clearly the wrong place
Type of Change
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyAdditional Notes
This is actively being discussed in discord channel refactor-run_coinbase