Skip to content

do not update (singular) BlockEmission for every subnet #1987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: devnet-ready
Choose a base branch
from
Open

do not update (singular) BlockEmission for every subnet #1987

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions pallets/subtensor/src/coinbase/block_emission.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,13 @@ impl<T: Config> Pallet<T> {
///
pub fn get_block_emission() -> Result<TaoCurrency, &'static str> {
// Convert the total issuance to a fixed-point number for calculation.
Self::get_block_emission_for_issuance(Self::get_total_issuance().into()).map(Into::into)
let block_emission =
Self::get_block_emission_for_issuance(Self::get_total_issuance().into());
let block_emission_u64: u64 = block_emission.unwrap_or(0);
if BlockEmission::<T>::get() != block_emission_u64 {
BlockEmission::<T>::put(block_emission_u64);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is not a good idea to update anything in a get method.

}
block_emission.map(Into::into)
}

/// Returns the block emission for an issuance value.
Expand Down Expand Up @@ -144,9 +150,6 @@ impl<T: Config> Pallet<T> {
.saturating_mul(I96F32::saturating_from_num(DefaultBlockEmission::<T>::get()));
// Convert to u64
let block_emission_u64: u64 = block_emission.saturating_to_num::<u64>();
if BlockEmission::<T>::get() != block_emission_u64 {
BlockEmission::<T>::put(block_emission_u64);
}
Ok(block_emission_u64)
}
}
Loading