OpenVINO/GenAI 12-08-2025 #3569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkalinowski
force-pushed
the
ov0809-dkalinow2
branch
from
e82a316 to
da90190
Compare
dkalinowski
commented
Aug 13, 2025
| @@ -187,6 +187,8 @@ WINDOWS_COMMON_STATIC_LIBS_COPTS = [ | |||
| "/GS", | |||
| "/DYNAMICBASE", | |||
| "/Qspectre", | |||
| "/wd4305", # abseil after switch to build tools 22 | |||
dkalinowski
commented
Aug 13, 2025
| :msvc_bt | ||
| echo [INFO] Using MSVC %VS_2022_BT% | ||
| set BAZEL_VS=%VS_2022_BT% | ||
|
|
||
| :: Bazel compilation settings end | ||
| :msvc_end | ||
| set "BAZEL_VC=%BAZEL_VS:"=%\VC" | ||
| set "BAZEL_VC_FULL_VERSION=14.29.30133" | ||
| set "BAZEL_VC_FULL_VERSION=14.44.35207" |
There was a problem hiding this comment.
check what happens when we remove this env
There was a problem hiding this comment.
we agreed with @atobiszei that it is more convenient to keep hardcoded version as @rasapala intended it to be.
this way, an user instead of seeing weird compilation error, will see that vc full version doesnt match. and we can upgrade it every X months and validate ourselves if OVMS still compiles with latest VC.
dtrawins
approved these changes
Aug 13, 2025
atobiszei
approved these changes
Aug 13, 2025
przepeck
pushed a commit
that referenced
this pull request
Aug 21, 2025
- Drop support for build tools 19, move to 22 (because xgrammar doesnt build with buildtools 19 - Patch nsync (dep of TF) to build on 22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.