-
Notifications
You must be signed in to change notification settings - Fork 218
OpenVINO/GenAI 12-08-2025 #3569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
85eeaaa
70cb045
b1ac3e2
78710ba
01128e7
da90190
a6e2489
c88ec41
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
diff --git a/tensorflow/workspace2.bzl b/tensorflow/workspace2.bzl | ||
index be83c971749..bd80e19896e 100644 | ||
--- a/tensorflow/workspace2.bzl | ||
+++ b/tensorflow/workspace2.bzl | ||
@@ -396,7 +396,7 @@ def _tf_repositories(): | ||
|
||
tf_http_archive( | ||
name = "nsync", | ||
- patch_file = ["//third_party:nsync.patch"], | ||
+ patch_file = ["//third_party:nsync.patch", "//third_party:nsync_chrono.patch"], | ||
sha256 = "1d63e967973733d2c97e841e3c05fac4d3fa299f01d14c86f2695594c7a4a2ec", | ||
strip_prefix = "nsync-1.29.2", | ||
system_build_file = "//third_party/systemlibs:nsync.BUILD", | ||
diff --git a/third_party/nsync_chrono.patch b/third_party/nsync_chrono.patch | ||
new file mode 100644 | ||
index 00000000000..7f0f8539727 | ||
--- /dev/null | ||
+++ b/third_party/nsync_chrono.patch | ||
@@ -0,0 +1,12 @@ | ||
+diff --git a/platform/c++11/platform.h b/platform/c++11/platform.h | ||
+index 2c80e0b..4fbc6d0 100644 | ||
+--- a/platform/c++11/platform.h | ||
++++ b/platform/c++11/platform.h | ||
+@@ -28,6 +28,7 @@ | ||
+ | ||
+ #include <mutex> | ||
+ #include <condition_variable> | ||
++#include <chrono> | ||
+ | ||
+ #include "nsync_cpp.h" | ||
+ |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -56,26 +56,20 @@ set "setPythonPath=%cd%\bazel-out\x64_windows-opt\bin\src\python\binding" | |
set "BAZEL_SH=C:\opt\msys64\usr\bin\bash.exe" | ||
|
||
:: Bazel compilation settings | ||
set VS_2019_PRO="C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional" | ||
set VS_2022_BT="C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools" | ||
IF /I EXIST %VS_2019_PRO% goto :msvc_pro | ||
IF /I EXIST %VS_2022_BT% goto :msvc_bt ELSE goto :msvc_error | ||
|
||
:msvc_error | ||
echo [ERROR] Required MSVC compiler not installed | ||
goto :exit_build_error | ||
:msvc_pro | ||
echo [INFO] Using MSVC %VS_2019_PRO% | ||
set BAZEL_VS=%VS_2019_PRO% | ||
goto :msvc_end | ||
:msvc_bt | ||
echo [INFO] Using MSVC %VS_2022_BT% | ||
set BAZEL_VS=%VS_2022_BT% | ||
|
||
:: Bazel compilation settings end | ||
:msvc_end | ||
set "BAZEL_VC=%BAZEL_VS:"=%\VC" | ||
set "BAZEL_VC_FULL_VERSION=14.29.30133" | ||
set "BAZEL_VC_FULL_VERSION=14.44.35207" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. check what happens when we remove this env There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we agreed with @atobiszei that it is more convenient to keep hardcoded version as @rasapala intended it to be. this way, an user instead of seeing weird compilation error, will see that vc full version doesnt match. and we can upgrade it every X months and validate ourselves if OVMS still compiles with latest VC. |
||
|
||
:: Set proper PATH environment variable: Remove other python paths and add c:\opt with bazel to PATH | ||
set "PATH=%setPath%" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pragma?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To follow up