[WeightCompression] Ignored patterns introduction #3562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
NNCF Common
daniil-lyakhov
changed the title
nikita-savelyevv
approved these changes
Jun 27, 2025
AlexanderDokuchaev
requested changes
Jun 30, 2025
daniil-lyakhov
force-pushed
the
dl/wc/ignored_patterns
branch
from
fc3ba76 to
1b01a78
Compare
github-actions
bot
removed
NNCF Common
Collaborator
Author
|
@AlexanderDokuchaev, I removed my approach and introduced your suggestion, please check |
AlexanderDokuchaev
requested changes
Jul 8, 2025
src/nncf/quantization/algorithms/weight_compression/algorithm.py
Outdated
Show resolved
Hide resolved
daniil-lyakhov
force-pushed
the
dl/wc/ignored_patterns
branch
from
e198c79 to
2f45264
Compare
AlexanderDokuchaev
requested changes
Jul 9, 2025
src/nncf/quantization/algorithms/weight_compression/algorithm.py
Outdated
Show resolved
Hide resolved
src/nncf/quantization/algorithms/weight_compression/algorithm.py
Outdated
Show resolved
Hide resolved
daniil-lyakhov
force-pushed
the
dl/wc/ignored_patterns
branch
from
6a309a4 to
4462ef2
Compare
daniil-lyakhov
force-pushed
the
dl/wc/ignored_patterns
branch
from
4462ef2 to
f4ef390
Compare
Co-authored-by: Alexander Dokuchaev <[email protected]>
AlexanderDokuchaev
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Ignored patterns are being introduced to the WeightCompression algorithm
Reason for changes
ROPE pattern breaks the logic of the WeightCompression algorithm, required to be automatically ignored
Related tickets
huggingface/optimum-intel#1295
164548
Tests
test_rope_weight_compression