Skip to content

feat: migrate mod builder#1980

Merged
arayikhalatyan merged 11 commits intofeat/tracegen-gpufrom
feat/migrate-mod-builder
Aug 18, 2025
Merged

feat: migrate mod builder#1980
arayikhalatyan merged 11 commits intofeat/tracegen-gpufrom
feat/migrate-mod-builder

Conversation

@arayikhalatyan
Copy link
Contributor

@arayikhalatyan arayikhalatyan commented Aug 15, 2025

mod-builder now compiles with build.rs but I used the system/controller.cuh from tracegen-gpu. let's wait until system is migrated

some of the diff comes from cargo update and cargo +nightly fmt -all

@github-actions

This comment has been minimized.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 18, 2025

CodSpeed WallTime Performance Report

Merging #1980 will improve performances by 11.25%

Comparing feat/migrate-mod-builder (e06bf61) with feat/new-execution (30221fb)1

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

⚡ 1 improvements
✅ 26 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
benchmark_execute[keccak256_iter] 134.4 ms 120.8 ms +11.25%

Footnotes

  1. No successful run was found on feat/tracegen-gpu (f4a9bf9) during the generation of this report, so feat/new-execution (6a916bc) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@github-actions

This comment has been minimized.

Copy link
Contributor

@stephenh-axiom-xyz stephenh-axiom-xyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanna say that we should simplify cuda_field_expression to cuda? We have a feature-gated cuda mod in several of our primitives

Copy link
Contributor

@stephenh-axiom-xyz stephenh-axiom-xyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM provided all CI pass

@github-actions
Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair 2,107 322,674 18,750,012 - - -
fibonacci 2,409 1,500,210 51,504,507 - - -
regex 7,635 4,108,597 164,734,992 - - -
ecrecover 1,348 140,487 8,866,654 - - -
pairing 3,869 1,882,939 98,834,293 - - -

Commit: e06bf61

Benchmark Workflow

@arayikhalatyan arayikhalatyan merged commit 26119b8 into feat/tracegen-gpu Aug 18, 2025
37 checks passed
@arayikhalatyan arayikhalatyan deleted the feat/migrate-mod-builder branch August 18, 2025 21:22
jonathanpwang pushed a commit that referenced this pull request Aug 19, 2025
migrated `mod-builder` cuda tracegen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants