feat: migrate mod builder#1980
Merged
arayikhalatyan merged 11 commits intofeat/tracegen-gpufrom Aug 18, 2025
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
CodSpeed WallTime Performance ReportMerging #1980 will improve performances by 11.25%Comparing
|
| Benchmark | BASE |
HEAD |
Change | |
|---|---|---|---|---|
| ⚡ | benchmark_execute[keccak256_iter] |
134.4 ms | 120.8 ms | +11.25% |
Footnotes
This comment has been minimized.
This comment has been minimized.
Contributor
stephenh-axiom-xyz
left a comment
There was a problem hiding this comment.
I wanna say that we should simplify cuda_field_expression to cuda? We have a feature-gated cuda mod in several of our primitives
stephenh-axiom-xyz
approved these changes
Aug 18, 2025
Contributor
stephenh-axiom-xyz
left a comment
There was a problem hiding this comment.
LGTM provided all CI pass
Commit: e06bf61 |
jonathanpwang
pushed a commit
that referenced
this pull request
Aug 19, 2025
migrated `mod-builder` cuda tracegen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mod-builder now compiles with build.rs but I used the
system/controller.cuhfrom tracegen-gpu. let's wait until system is migratedsome of the diff comes from
cargo updateandcargo +nightly fmt -all