-
Notifications
You must be signed in to change notification settings - Fork 95
feat: migrate mod builder #1980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
5859bb9
migrate mod-builder
arayikhalatyan 153b56b
add build.rs
arayikhalatyan 832c592
Merge branch 'feat/tracegen-gpu' into feat/migrate-mod-builder
arayikhalatyan c8a6167
update and fixes
arayikhalatyan 73440d3
Merge branch 'feat/tracegen-gpu' into feat/migrate-mod-builder
arayikhalatyan 495f7bb
remove cuda from default
arayikhalatyan 6c8ec3a
Merge branch 'feat/tracegen-gpu' into feat/migrate-mod-builder
arayikhalatyan 66e6bd4
reviewer comments
arayikhalatyan 016997c
lints
arayikhalatyan 3c7f427
fix build.rs
arayikhalatyan e06bf61
nit build.rs
arayikhalatyan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| #[cfg(feature = "cuda")] | ||
| use openvm_cuda_builder::{cuda_available, CudaBuilder}; | ||
|
|
||
| #[cfg(feature = "cuda")] | ||
| fn main() { | ||
| if !cuda_available() { | ||
| return; // Skip CUDA compilation | ||
| } | ||
|
|
||
| let builder = CudaBuilder::new() | ||
| .include_from_dep("DEP_CUDA_COMMON_INCLUDE") // Import headers | ||
| .include("../primitives/cuda/include") | ||
| .include("cuda/include") | ||
| .include("../../../extensions/rv32-adapters/cuda/include") | ||
| .include("../poseidon2-air/cuda/include") | ||
| .include("../../../tracegen-gpu/cuda/src") // TODO[arayi]: change once system is migrated | ||
| .watch("src/cuda_abi.rs") | ||
| .watch("cuda") | ||
| .watch("../primitives/cuda/include") | ||
| .watch("../../../extensions/rv32-adapters/cuda/include") | ||
| .watch("../poseidon2-air/cuda/include") | ||
| .watch("../../../tracegen-gpu/cuda/src") // TODO[arayi]: change once system is migrated | ||
| .library_name("tracegen_mod_builder") | ||
| .file("cuda/src/field_expression.cu"); | ||
|
|
||
| builder.emit_link_directives(); | ||
| builder.build(); | ||
| } | ||
|
|
||
| #[cfg(not(feature = "cuda"))] | ||
| fn main() {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
crates/circuits/mod-builder/cuda/include/rv32_vec_heap_router.cuh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 6 additions & 6 deletions
12
.../cuda/src/mod_builder/field_expression.cu → .../mod-builder/cuda/src/field_expression.cu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
2 changes: 1 addition & 1 deletion
2
tracegen-gpu/src/mod_builder/expr_op.rs → .../circuits/mod-builder/src/cuda/expr_op.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| mod chip; | ||
| mod constants; | ||
| mod expr_op; | ||
| mod types; | ||
|
|
||
| pub use types::*; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 2 additions & 1 deletion
3
.../src/mod_builder/field_expression/cuda.rs → crates/circuits/mod-builder/src/cuda_abi.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.