[change] Moved python dependencies to requirements.txt files for maintainability #529
Conversation
There was a problem hiding this comment.
Let's do the same for the optional python dependencies (postgresql, mysql, etc), we can create multiple files, eg: requirements-postgresql.txt, requirements-mysql.txt, etc (we can ignore raven for sentry which is deprecated).
Double check the dependabot config matches what we have in the wireguard role which is working as we need: https://github.com/openwisp/ansible-wireguard-openwisp/blob/main/.github/dependabot.yml#L3-L8 (I mean that dependabot is successfully reminding us to update the dependencies).
github-project-automation
bot
moved this to In progress
in OpenWISP Priorities for next releases
| openwisp_controller.config.tests.test_admin.TestAdmin.test_vpn_preview_button \ | ||
| openwisp_controller.config.tests.test_admin.TestAdmin.test_device_queryset \ | ||
| openwisp_controller.config.tests.test_admin.TestAdmin.test_device_organization_fk_autocomplete_view \ | ||
| openwisp_controller.config.tests.test_admin.TestAdmin.test_device_templates_m2m_queryset \ |
There was a problem hiding this comment.
Since this test was removed in openwisp/openwisp-controller#1010, so I removed it here. I later tried to use the selenium equivalent test, but the test run failed because the selenium package isn’t installed.
Should we add selenium (and this test) back?
There was a problem hiding this comment.
Yes it would be useful to run selenium tests, please open an issue for this and we can follow up after this is merged.
nemesifier
changed the title
nemesifier
changed the title
nemesifier
changed the title
There was a problem hiding this comment.
@nemesifier are you sure about having three different requirements.txt in /opt/openwisp2?
If possible, I would look for a way to merge the files into one requirements.txt on the remote system.
There was a problem hiding this comment.
What's the advantage? I don't see any.. and I see the disadvantage that the tasks building the unified requirements.txt file may not be idempotent.
There was a problem hiding this comment.
At that moment, I thought that it would simply re-installing the dependencies manually on the target machine if required.
Now, I think we should promote users to only use the ansible role to manage dependencies. I agree with your conclusion.
github-project-automation
bot
moved this from In progress
to Reviewer approved
in OpenWISP Priorities for next releases
github-project-automation
bot
moved this from Reviewer approved
to Done
in OpenWISP Priorities for next releases
Closes #507