-
-
Notifications
You must be signed in to change notification settings - Fork 152
[change] Moved python dependencies to requirements.txt files for maintainability #529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
6420902
0e44b85
ed9e2c5
b5ebfc6
6d717a5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| django-celery-email~=3.0.0 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| django-cors-headers~=4.4.0 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| mysqlclient~=2.2 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| psycopg2~=2.9 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| channels_redis~=4.2.0 | ||
| django-redis~=5.4.0 | ||
| django-pipeline~=3.1.0 | ||
| uwsgi~=2.0.30 |
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @nemesifier are you sure about having three different requirements.txt in If possible, I would look for a way to merge the files into one requirements.txt on the remote system.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's the advantage? I don't see any.. and I see the disadvantage that the tasks building the unified requirements.txt file may not be idempotent.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. At that moment, I thought that it would simply re-installing the dependencies manually on the target machine if required. Now, I think we should promote users to only use the ansible role to manage dependencies. I agree with your conclusion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this test was removed in openwisp/openwisp-controller#1010, so I removed it here. I later tried to use the selenium equivalent test, but the test run failed because the selenium package isn’t installed.
Should we add selenium (and this test) back?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it would be useful to run selenium tests, please open an issue for this and we can follow up after this is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created #530 @nemesifier