Skip to content

[django 5:css] Fixed styling of device location inline#1007

Closed
pandafy wants to merge 2 commits intomasterfrom
fix-django-styling
Closed

[django 5:css] Fixed styling of device location inline#1007
pandafy wants to merge 2 commits intomasterfrom
fix-django-styling

Conversation

@pandafy
Copy link
Member

@pandafy pandafy commented Apr 11, 2025

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • I have updated the documentation.

image

@pandafy pandafy moved this from To do (general) to Needs review in OpenWISP Contributor's Board Apr 11, 2025
@pandafy pandafy force-pushed the fix-django-styling branch from a7d01a3 to ad7c177 Compare April 11, 2025 15:14
#devicelocation-0-2-heading {
font-size: 16px;
text-transform: uppercase;
padding: 15px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the problem generalized? I was wondering if we should look for a generic solution for all the headers. Are you sure we need to change only this one?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Myabe, we can generalize this using the following rule

.inline-related fieldset.module h4 {
  font-size: 16px;
  text-transform: uppercase;
  padding: 15px;
}

But, this will make heading of all fieldsets bigger.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a side-effect of this now in openwisp-monitoring.

@pandafy pandafy force-pushed the fix-django-styling branch from ad7c177 to ec1c4c6 Compare April 11, 2025 17:19
@coveralls
Copy link

Coverage Status

coverage: 98.855%. remained the same
when pulling 4471c35 on fix-django-styling
into 751e9b2 on master.

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even with these adjustments it doesn't look as before.

New (Firmware Build):

Screenshot from 2025-05-06 18-58-10

Old (Firmware Build):

Screenshot from 2025-05-06 19-12-56

Old (device page):

Screenshot from 2025-05-06 19-14-11

Moreover, are we sure we shouldn't add the generic solution to openwisp-utils?

@github-project-automation github-project-automation bot moved this from Needs review to In progress in OpenWISP Contributor's Board May 6, 2025
@pandafy
Copy link
Member Author

pandafy commented May 7, 2025

Superseded by openwisp/openwisp-utils#470 and openwisp/django-loci#174

@pandafy pandafy closed this May 7, 2025
@github-project-automation github-project-automation bot moved this from In progress to Done in OpenWISP Contributor's Board May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants