Skip to content

[django 5:css] Fixed styling of device location inline #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pandafy wants to merge 2 commits into from
Closed

[django 5:css] Fixed styling of device location inline #1007

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec1c4c6
[django 5:css] Fixed styling of device location inline
pandafy Apr 11, 2025
4471c35
Merge branch 'master' into fix-django-styling
nemesifier May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions openwisp_controller/config/static/config/css/admin.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@ div.change-form
div.inline-group.tab-content
> fieldset.module
> h2,
#devicelocation-0-1-heading,
div.change-form
#device_form
div.inline-group.tab-content
Expand Down Expand Up @@ -230,6 +231,11 @@ div.change-form #device_form > div > div.inline-group {
.change-form #device_form div.inline-group.tab-content > .tabular {
margin-top: -1em;
}
.inline-related fieldset.module h4 {
font-size: 16px;
text-transform: uppercase;
padding: 15px;
Copy link
Member

@nemesifier nemesifier Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the problem generalized? I was wondering if we should look for a generic solution for all the headers. Are you sure we need to change only this one?

Copy link
Member Author

@pandafy pandafy Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Myabe, we can generalize this using the following rule

.inline-related fieldset.module h4 {
  font-size: 16px;
  text-transform: uppercase;
  padding: 15px;
}

But, this will make heading of all fieldsets bigger.

Copy link
Member Author

@pandafy pandafy Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a side-effect of this now in openwisp-monitoring.

}
#main .tab-content .inline-related > h3 {
background: transparent;
}
Expand Down
Loading