[tests] Made selenium tests resilient to failures #990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to To do (general)
in OpenWISP Contributor's Board
pandafy
force-pushed
the
update-selenium-tests
branch
from
1259e7e to
3be9dc9
Compare
pandafy
force-pushed
the
update-selenium-tests
branch
from
3be9dc9 to
1989ad6
Compare
nemesifier
reviewed
Mar 13, 2025
openwisp_controller/tests/utils.py
Outdated
| self.web_driver.refresh() | ||
| except UnexpectedAlertPresentException: | ||
| self.web_driver.switch_to_alert().accept() | ||
| self.web_driver.switch_to_alert.accept() |
| from django.contrib.staticfiles.testing import StaticLiveServerTestCase | ||
| from django.test import tag | ||
| from django.urls import reverse | ||
| import ipdb |
pandafy
force-pushed
the
update-selenium-tests
branch
2 times, most recently
from
7aa1b0b to
c957448
Compare
pandafy
force-pushed
the
update-selenium-tests
branch
from
c957448 to
990bf08
Compare
pandafy
force-pushed
the
update-selenium-tests
branch
from
28fddb8 to
15ed708
Compare
pandafy
commented
Mar 14, 2025
.github/workflows/ci.yml
Outdated
| pip install -U pip wheel setuptools | ||
| pip install -U -r requirements-test.txt | ||
| pip install -U -e . | ||
| pip install -UI --no-deps https://github.com/openwisp/openwisp-utils/tarball/browser-logs |
There was a problem hiding this comment.
TODO: Remove this before merging
Suggested change
| pip install -UI --no-deps https://github.com/openwisp/openwisp-utils/tarball/browser-logs |
nemesifier
requested changes
Mar 14, 2025
openwisp_controller/tests/utils.py
Outdated
| self._assert_loading_overlay_hidden() | ||
|
|
||
| def _assert_loading_overlay_hidden(self): | ||
| self.wait_for_invisibility(By.CSS_SELECTOR, '#loading-overlay') |
There was a problem hiding this comment.
Maybe we want to centralize this in openwisp-utils as I added something similar in openwisp-monitoring, but I had to hide the overlay explicitly as doing this was not enough.
github-project-automation
bot
moved this from To do (general)
to In progress
in OpenWISP Contributor's Board
nemesifier
approved these changes
Mar 14, 2025
nemesifier
requested changes
Mar 14, 2025
pandafy
force-pushed
the
update-selenium-tests
branch
2 times, most recently
from
8c010a8 to
2ea4fe5
Compare
pandafy
force-pushed
the
update-selenium-tests
branch
from
2ea4fe5 to
87497fd
Compare
nemesifier
requested changes
Mar 17, 2025
| with self.subTest('Alert should be displayed after making changes'): | ||
| # The WebDriver automatically accepts the | ||
| # beforeunload confirmation dialog. To verify the message, | ||
| # we log it to the console and check its content. |
There was a problem hiding this comment.
Suggested change
| # we log it to the console and check its content. | |
| # we log it to the console and check its content. | |
| # | |
| # our own JS code sets e.returnValue when triggered | |
| # so we just need to ensure it's set as expected |
pandafy
force-pushed
the
update-selenium-tests
branch
from
ee1b3a5 to
fa4d7e9
Compare
pandafy
force-pushed
the
update-selenium-tests
branch
7 times, most recently
from
705c03d to
1e4e8dc
Compare
pandafy
force-pushed
the
update-selenium-tests
branch
from
1e4e8dc to
ffef8c1
Compare
4 tasks
pandafy
force-pushed
the
update-selenium-tests
branch
3 times, most recently
from
9938eb0 to
f70dcab
Compare
pandafy
force-pushed
the
update-selenium-tests
branch
from
f70dcab to
6795f36
Compare
|
The random failures that we observed in the following builds were due to port collision in geckodriver.
There's already a PR in selenium which addresses this issue |
pandafy
force-pushed
the
update-selenium-tests
branch
from
0df75f8 to
930d094
Compare
nemesifier
approved these changes
Mar 20, 2025
github-project-automation
bot
moved this from In progress
to Done
in OpenWISP Contributor's Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist