Drop failure case for stablehlo.dynamic_broadcast_in_dim#2770
Drop failure case for stablehlo.dynamic_broadcast_in_dim#2770rsuderman wants to merge 4 commits intoopenxla:mainfrom
stablehlo.dynamic_broadcast_in_dim#2770Conversation
The failure to broadcast dynamically makes the assumption the input dynamic shape could be expanded by being `1`. This should be handled by an earlier trasform to materialize a known broadcast if we intend to support both cases.
6a197ca to
e0b92bb
Compare
|
@GleasonK if you do not mind looking over. I believe there is a way to safely introduce the conditional broadcasting but it depends on how |
|
Could you say more about requirement on lowering of get_dimension_size? Also is that what's happening at the moment via the lowering to linalg path? |
There is no current lowering in the Something worth noting is to have the conditional broadcast (e.g. |
The failure to broadcast dynamically makes the assumption the input dynamic shape could be expanded by being
1. This should be handled by an earlier trasform to materialize a known broadcast if we intend to support both cases.