Tag PjRt migration candidates explicitly. (BUILD changes) #36020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_852941506
branch
4 times, most recently
from
0a57dac to
4616f1a
Compare
This change adds a new tag "pjrt_migration_candidate" to all test targets that depend on HloTestBase, ClientLibraryTestBase, and HloRunnerTpuSystem. This change also adds a new `use_legacy_runtime` kwarg to `xla_test`, which acts as a replacement for "test_migrated_to_hlo_runner_pjrt". During a brief transition phase, we will leave all "test_migrated_to_hlo_runner_pjrt" tags in place so that we can identify any tests that have the `use_legacy_runtime` set to an incorrect value. "pjrt_migration_candidate" and "test_migrated_to_hlo_runner_pjrt" are mutually exclusive. "pjrt_migration_candidate" should not appear on any tests using the new runtime. Unlike "test_migrated_to_hlo_runner_pjrt", which primarily tags `xla_test` targets, "pjrt_migration_candidate" intends to tag all outstanding migration candidates to obtain an accurate picture of migration progress. If a test cannot or should not be migrated, it can be excluded from any analysis just by removing the tag. PiperOrigin-RevId: 853290940
copybara-service
bot
force-pushed
the
test_852941506
branch
from
4616f1a to
b74b7d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tag PjRt migration candidates explicitly. (BUILD changes)
This change adds a new tag "pjrt_migration_candidate" to all test targets that
depend on HloTestBase, ClientLibraryTestBase, and HloRunnerTpuSystem.
This change also adds a new
use_legacy_runtimekwarg toxla_test, which actsas a replacement for "test_migrated_to_hlo_runner_pjrt". During a brief
transition phase, we will leave all "test_migrated_to_hlo_runner_pjrt" tags in
place so that we can identify any tests that have the
use_legacy_runtimesetto an incorrect value.
"pjrt_migration_candidate" and "test_migrated_to_hlo_runner_pjrt" are mutually
exclusive.
"pjrt_migration_candidate" should not appear on any tests using the new runtime.
Unlike "test_migrated_to_hlo_runner_pjrt", which primarily tags
xla_testtargets, "pjrt_migration_candidate" intends to tag all outstanding migration
candidates to obtain an accurate picture of migration progress. If a test cannot
or should not be migrated, it can be excluded from any analysis just by removing
the tag.