✨ Fix a flake in upgrade e2e #1346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a potential for nil pointer dereference in the test. This change adds condition to check for nil. Signed-off-by: Mikalai Radchuk <[email protected]>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1346 +/- ##
=======================================
Coverage 76.37% 76.37%
=======================================
Files 41 41
Lines 2438 2438
=======================================
Hits 1862 1862
Misses 402 402
Partials 174 174
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
m1kola
commented
Oct 4, 2024
| assert.Equal(ct, metav1.ConditionTrue, cond.Status) | ||
| assert.Equal(ct, ocv1alpha1.ReasonSuccess, cond.Reason) | ||
| assert.Contains(ct, cond.Message, "Installed bundle") | ||
| if assert.NotEmpty(ct, clusterExtension.Status.Install.Bundle) { |
There was a problem hiding this comment.
clusterExtension.Status.Install.Bundle is not a pointer and it doesn't make much sense to check for it being empty: we can just check the value (Version) we care about after checking that clusterExtension.Status.Install is not nil.
joelanford
approved these changes
Oct 4, 2024
Merged
via the queue into
operator-framework:main
with commit Oct 4, 2024
8466890
17 of 19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a potential for nil pointer dereference in the test. This change adds condition to check for nil.
Example failures:
Reviewer Checklist