Skip to content

Conversation

@anik120
Copy link
Contributor

@anik120 anik120 commented Jun 23, 2025

Follow up to 2034

When there is a dual namespace deployment, the default-deny-all policy is duplicated in both namespaces.

This PR updates the list of allowedPolicies to include both policies if a dual namespace deployment is detected.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Follow up to (2034)[operator-framework#2034]

When there is a dual namespace deployment, the default-deny-all policy
is duplicated in both namespaces.

This PR updates the list of `allowedPolicies` to include both policies
if a dual namespace deployment is detected.
@anik120 anik120 requested a review from a team as a code owner June 23, 2025 18:10
@netlify
Copy link

netlify bot commented Jun 23, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 1f51575
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6859988d6a04280008ef03c8
😎 Deploy Preview https://deploy-preview-2039--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Jun 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.81%. Comparing base (dffa0f6) to head (1f51575).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2039   +/-   ##
=======================================
  Coverage   73.81%   73.81%           
=======================================
  Files          80       80           
  Lines        7154     7154           
=======================================
  Hits         5281     5281           
  Misses       1550     1550           
  Partials      323      323           
Flag Coverage Δ
e2e 44.10% <ø> (ø)
unit 60.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort
Copy link
Contributor

tmshort commented Jun 23, 2025

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jun 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit d844c45 into operator-framework:main Jun 23, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants