Skip to content

🐛 (e2e) fix default-deny-all in list of allowed policies for test #2039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025
Merged

🐛 (e2e) fix default-deny-all in list of allowed policies for test #2039

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions test/e2e/network_policy_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,15 @@ type allowedPolicyDefinition struct {
denyAllEgressJustification string // Justification if Egress is in PolicyTypes and EgressRules is empty
}

var denyAllPolicySpec = allowedPolicyDefinition{
selector: metav1.LabelSelector{}, // Empty selector, matches all pods
policyTypes: []networkingv1.PolicyType{networkingv1.PolicyTypeIngress, networkingv1.PolicyTypeEgress},
// No IngressRules means deny all ingress if PolicyTypeIngress is present
// No EgressRules means deny all egress if PolicyTypeEgress is present
denyAllIngressJustification: "Denies all ingress traffic to pods selected by this policy by default, unless explicitly allowed by other policy rules, ensuring a baseline secure posture.",
denyAllEgressJustification: "Denies all egress traffic from pods selected by this policy by default, unless explicitly allowed by other policy rules, minimizing potential exfiltration paths.",
}

// Ref: https://docs.google.com/document/d/1bHEEWzA65u-kjJFQRUY1iBuMIIM1HbPy4MeDLX4NI3o/edit?usp=sharing
var allowedNetworkPolicies = map[string]allowedPolicyDefinition{
"catalogd-controller-manager": {
Expand Down Expand Up @@ -106,14 +115,6 @@ var allowedNetworkPolicies = map[string]allowedPolicyDefinition{
},
},
},
"default-deny-all-traffic": {
selector: metav1.LabelSelector{}, // Empty selector, matches all pods
policyTypes: []networkingv1.PolicyType{networkingv1.PolicyTypeIngress, networkingv1.PolicyTypeEgress},
// No IngressRules means deny all ingress if PolicyTypeIngress is present
// No EgressRules means deny all egress if PolicyTypeEgress is present
denyAllIngressJustification: "Denies all ingress traffic to pods selected by this policy by default, unless explicitly allowed by other policy rules, ensuring a baseline secure posture.",
denyAllEgressJustification: "Denies all egress traffic from pods selected by this policy by default, unless explicitly allowed by other policy rules, minimizing potential exfiltration paths.",
},
}

func TestNetworkPolicyJustifications(t *testing.T) {
Expand Down Expand Up @@ -155,6 +156,13 @@ func TestNetworkPolicyJustifications(t *testing.T) {
err := c.List(ctx, policies, client.InNamespace(catalogDNamespace))
require.NoError(t, err, "Failed to list NetworkPolicies in namespace %q", catalogDNamespace)
clusterPolicies = append(clusterPolicies, policies.Items...)

t.Log("Detected dual-namespace configuration, expecting two prefixed 'default-deny-all-traffic' policies.")
allowedNetworkPolicies["catalogd-default-deny-all-traffic"] = denyAllPolicySpec
allowedNetworkPolicies["operator-controller-default-deny-all-traffic"] = denyAllPolicySpec
} else {
t.Log("Detected single-namespace configuration, expecting one 'default-deny-all-traffic' policy.")
allowedNetworkPolicies["default-deny-all-traffic"] = denyAllPolicySpec
}

validatedRegistryPolicies := make(map[string]bool)
Expand Down