🐛 Revert "migrate containers libs to new mono-repo" #2215
Conversation
This reverts PR2195 This reverts commit febdb59. Signed-off-by: Todd Short <[email protected]>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/hold Alternatively, we can try to update operator-registry and pull that in ASAP, because this is blocking downstreaming. |
openshift-ci
bot
added
the
do-not-merge/hold
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2215 +/- ##
=======================================
Coverage 72.06% 72.06%
=======================================
Files 85 85
Lines 8401 8401
=======================================
Hits 6054 6054
Misses 1943 1943
Partials 404 404
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
openshift-merge-bot
bot
merged commit d0c7c0c
into
operator-framework:main
…amework#2215" new operator-registry.v1.59.0 release contains migration, which should fix the issue that necessitated operator-framework#2215
new operator-registry.v1.59.0 release contains migration, which should fix the issue that necessitated operator-framework#2215
PR #2195 broke the downstream build.
It seems that when this is downstreamed, and subsequently vendored and built within a container build that it's not entire rid of
containers/images, asoperator-framework/operator-registrystill uses it, so there's still an indirect reference tocontainers/imagesin go.mod.Reverting this in the downstream PR fixes the downstream build.
This reverts commit febdb59.
Description
Reviewer Checklist