-
Notifications
You must be signed in to change notification settings - Fork 67
🐛 OPRUN-4166: Use long name for curl image #2235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 OPRUN-4166: Use long name for curl image #2235
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
/approve |
The short name was causing downstream issues: ``` image name curlimages/curl:8.15.0 returns ambiguous list ``` Using the long name seems to fix this. Signed-off-by: Todd Short <[email protected]>
941b658
to
2b97b47
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jianzhangbjz, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2235 +/- ##
=======================================
Coverage 71.84% 71.84%
=======================================
Files 86 86
Lines 8474 8474
=======================================
Hits 6088 6088
Misses 1984 1984
Partials 402 402
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
55d9dfb
into
operator-framework:main
The short name was causing downstream issues:
Using the long name seems to fix this.
Already tested downstream.
Reviewer Checklist