Skip to content

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Sep 25, 2025

The short name was causing downstream issues:

image name curlimages/curl:8.15.0 returns ambiguous list

Using the long name seems to fix this.

Already tested downstream.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort tmshort requested a review from a team as a code owner September 25, 2025 03:32
Copy link

netlify bot commented Sep 25, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 2b97b47
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/68d4bcad466f9b00085846ab
😎 Deploy Preview https://deploy-preview-2235--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@jianzhangbjz
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2025
The short name was causing downstream issues:

```
image name curlimages/curl:8.15.0 returns ambiguous list
```

Using the long name seems to fix this.

Signed-off-by: Todd Short <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2025
@tmshort
Copy link
Contributor Author

tmshort commented Sep 25, 2025

/approve

Copy link

openshift-ci bot commented Sep 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianzhangbjz, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2025
@dtfranz
Copy link
Contributor

dtfranz commented Sep 25, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2025
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.84%. Comparing base (0faf118) to head (2b97b47).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2235   +/-   ##
=======================================
  Coverage   71.84%   71.84%           
=======================================
  Files          86       86           
  Lines        8474     8474           
=======================================
  Hits         6088     6088           
  Misses       1984     1984           
  Partials      402      402           
Flag Coverage Δ
e2e 39.07% <ø> (-0.08%) ⬇️
experimental-e2e 46.17% <ø> (ø)
unit 56.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-merge-bot openshift-merge-bot bot merged commit 55d9dfb into operator-framework:main Sep 25, 2025
24 checks passed
@tmshort tmshort changed the title 🐛 Use long name for curl image 🐛 OPRUN-4166: Use long name for curl image Sep 25, 2025
@tmshort tmshort deleted the use-long-name branch September 25, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants