move wait-for-db from initContainer to container to support istio inje… #265
+4
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our environment we are using rke2 for kubernetes and istio for the service mesh. Given that the wait-for-db container is defined as an initContainer, it runs prior to the istio-proxy, thus can not connect to the database.
This proposed change moves the container element to include the wait-for-db definition and adds an empty list for initContainers. This change, along with an istio setting of holdApplicationUntilProxyStarts=true, allows the istio-proxy to execute, setting up the required networking to access the database.